Skip to content

Revert "refactor(api): migrate ToJSON instances to use experimental Era type" - #1048

Merged
Jimbo4350 merged 1 commit into
masterfrom
jordan/revert-1038
Dec 5, 2025
Merged

Jimbo4350 merged 1 commit into
masterfrom
jordan/revert-1038

Conversation

@Jimbo4350

Copy link
Copy Markdown
Contributor

This reverts commit 21408c8.

Changelog

- description: |
    The reverted PR breaks the query utxo command in cardano-cli which is supposed to be compatible for all shelley based eras.
  type:
  - bugfix         
  projects:
  - cardano-api

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

prop_json_roundtrip_utxo :: Property
prop_json_roundtrip_utxo = H.property $ do
utxo <- forAll $ genUTxO testEra
utxo <- forAll $ genUTxO ShelleyBasedEraBabbage

@carbolymer carbolymer Dec 23, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that this was just a quick revert, but the previous version was better. Actually, we should make sure those instances rountrip for all eras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants