Skip to content

wb | simplify and remove dependencies - #5957

Merged
fmaste merged 7 commits into
masterfrom
bench-podman
Sep 12, 2024
Merged

fmaste merged 7 commits into
masterfrom
bench-podman

Conversation

@fmaste

@fmaste fmaste commented Aug 21, 2024 •

Copy link
Copy Markdown
Contributor

Description

  • Remove support for the podman Nomad plugin (workbench's -nomadpodman sub-backend).
  • Remove uses of the Nomad version that comes from nixpkgs. Always use SRE patched version of Nomad based on version 1.6.3 that adds support for Nix dependencies.
  • Remove publish functionality dependencies while the new infrastructure is decided.
  • Cleanups: remove vault, nix2container and simplify some of the code.
  • Update container-enabled OpenSSH to the latest version.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste
fmaste force-pushed the bench-podman branch 2 times, most recently from a945f14 to 6330fca Compare September 3, 2024 19:06
@fmaste fmaste changed the title WIP wb | simplify and remove dependencies Sep 3, 2024
@fmaste
fmaste force-pushed the bench-podman branch 7 times, most recently from 37d24fc to 5d8c356 Compare September 10, 2024 18:58
@fmaste
fmaste marked this pull request as ready for review September 11, 2024 15:03
@fmaste
fmaste requested a review from a team September 11, 2024 15:03
@fmaste
fmaste requested review from a team as code owners September 11, 2024 15:03

@mgmeier mgmeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you @fmaste

@mgmeier
mgmeier added this pull request to the merge queue Sep 12, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2024
@fmaste
fmaste added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit 0841051 Sep 12, 2024
@fmaste
fmaste deleted the bench-podman branch September 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants