Skip to content

Fix bulk credentials path to construct PraosCredentialsSource - #6502

Merged
Jimbo4350 merged 1 commit into
masterfrom
fix/bulk-credentials-praos
Mar 30, 2026
Merged

Jimbo4350 merged 1 commit into
masterfrom
fix/bulk-credentials-praos

Conversation

@Jimbo4350

@Jimbo4350 Jimbo4350 commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #6503

Summary

  • Fix parseShelleyCredentials in the bulk credential path to properly destructure OperationalCertificate and KesSigningKey, construct a PraosCredentialsUnsound, and pass it to mkPraosLeaderCredentials
  • Mirrors the singleton credential path which was already updated for the new PraosCredentialsSource API
  • Applies fourmolu formatting to the file

Test plan

  • Verify cardano-node compiles with bulk credential configuration
  • Verify bulk credential loading works end-to-end in a test cluster

The bulk credential parsing was calling mkPraosLeaderCredentials with
the old applicative-style signature. Update parseShelleyCredentials to
destructure OperationalCertificate and KesSigningKey, build a
PraosCredentialsUnsound, and pass it to mkPraosLeaderCredentials,
mirroring the singleton credential path.
@Jimbo4350
Jimbo4350 force-pushed the fix/bulk-credentials-praos branch from 63af5aa to 2cb6bea Compare March 30, 2026 14:27
@Jimbo4350
Jimbo4350 marked this pull request as ready for review March 30, 2026 14:28
@Jimbo4350
Jimbo4350 requested a review from a team as a code owner March 30, 2026 14:28
@Jimbo4350
Jimbo4350 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into master with commit 58f0953 Mar 30, 2026
32 checks passed
@Jimbo4350
Jimbo4350 deleted the fix/bulk-credentials-praos branch March 30, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Bulk credentials parsing broken in 10.7.0

3 participants