Skip to content

Poll for node exit in startNode instead of racing waitForProcess - #6750

Merged
palas merged 2 commits into
masterfrom
fix-ci-hang
Oct 29, 2026
Merged

palas merged 2 commits into
masterfrom
fix-ci-hang

Conversation

@palas

@palas palas commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

There is an issue lately that is causing the GHA to hang forever in tests. This PR tries to address it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@palas palas self-assigned this Oct 28, 2026
@palas
palas requested a review from a team as a code owner October 28, 2026 17:02
Comment thread cardano-testnet/src/Testnet/Runtime.hs Resolved
Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
@palas
palas added this pull request to the merge queue Oct 28, 2026
Merged via the queue into master with commit 8edbc1c Oct 29, 2026
36 of 38 checks passed
@palas
palas deleted the fix-ci-hang branch October 29, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants