TUI: Migrate sidebar-item hover popup to a shared tooltip builder

[JDonaghy]

Tier: Small gap (needs panel-anchored tooltip variant in render.rs, or a generalized anchor on the existing builder)

Summary

render_panel_hover_popup() in src/tui_main/panels.rs:1526–1727 (~200 lines, 35+ `set_cell` calls) draws the sidebar-item hover popup by hand — box-drawing border, per-line markdown-style dispatch (`MdStyle` enum), byte-to-character mapping for style spans, and link hit-rect computation. The shared hover_popup_to_quadraui_tooltip() builder in render.rs:953 already does the same job for editor-anchored popups (which render_impl.rs:519 correctly delegates through). The sidebar-item variant is the only remaining hand-rolled popup path.

What exists

• render::hover_popup_to_quadraui_tooltip(hover, x, y, viewport) -> (Tooltip, TooltipLayout) — builds quadraui Tooltip with positioning.
• quadraui::tui::draw_tooltip() — TUI rasteriser, already wired (tui_main/quadraui_tui.rs:86).
• render_editor_hover_popup() (panels.rs:1736) — already uses editor_hover_to_quadraui_rich_text() + draw_rich_text_popup() (confirmed converged; no duplication there).
• Editor hover popup in render_impl.rs:519 already calls the shared tooltip builder.

What to do

1. Decide on the anchor model. The sidebar hover positions the popup to the right of the sidebar at the hovered item's row; the editor hover positions it near the cursor. Either:
   • Option A: Generalize hover_popup_to_quadraui_tooltip() to accept an anchor strategy (right-of-rect, above-cursor, etc.), or
   • Option B: Add a sibling panel_hover_to_quadraui_tooltip(hover, sidebar_right_x, item_y, viewport) in render.rs that produces the same (Tooltip, TooltipLayout) shape.
2. Replace render_panel_hover_popup() body with: build via the shared fn, draw via quadraui::tui::draw_tooltip(), extract link_hit_regions from the returned layout.
3. Delete the manual border drawing, per-line MdStyle matching, and byte-to-character mapping in panels.rs:1589–1706.

Files

• src/render.rs — small addition (~30 lines for an anchor-variant builder or anchor-strategy enum).
• src/tui_main/panels.rs — replace render_panel_hover_popup() body (~200 lines → ~30 lines of wiring).

Dependencies

Minor render.rs change to expose a panel-anchor positioning variant. No quadraui-side work needed (Tooltip primitive already supports the data shape).

Notes

Part of the TUI convergence backlog (#474). The editor hover popup at panels.rs:1736 is already converged — only the sidebar-item path is hand-rolled. Don't touch the editor path.

[JDonaghy]

Coordinator: Advisory — Worker Exited With 0 Commits

Machine: elitebook
Status: advisory
Duration: 5m 59s

The worker exited cleanly (exit code 0) but pushed no commits. This typically means the feature was already implemented or no change was needed. Human review is required to decide the next step.

Worker note

Human-attended chat session closed (diagnostic-only — no committed work).

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: —

Summary

Implemented #478: migrated render_panel_hover_popup() in panels.rs to build via new render::panel_hover_to_quadraui_rich_text() + quadraui::RichTextPopup::layout()/draw_rich_text_popup(), same pattern as the already-converged render_editor_hover_popup(). Extracted shared markdown/link-conversion helpers in render.rs (reused by both editor and panel hover builders) to avoid duplication. ~200 hand-rolled lines -> ~35 lines of wiring. No quadraui changes needed. Build clean (no warnings), clippy -D warnings clean, cargo fmt clean, full test suite passed (44/44 binaries, exit 0). Committed as 661d3c3 and pushed to issue-478-tui-migrate-sidebar-item-hover-popup-to.

[JDonaghy]

⏱ Needs attention

Machine: elitebook
Assignment: 60d1b817b65f
Issue: #478
Reason: Running too long

Running 94.6m, past the 20m threshold for type='smoke'.

Detection + surfacing only — nothing was killed or reassigned. A human should take a look; use coord log <id> to see what it's doing, or coord retry/coord stop to intervene.

[JDonaghy]

Coordinator: Assignment Complete

Machine: elitebook
Status: done
Exit code: 0
Duration: 4h 52m

[JDonaghy]

Coordinator: Assignment Complete

Machine: elitebook
Status: done
Exit code: 0
Duration: —

Summary

Smoke test passed: sidebar hover popup renders correctly via shared builder, dismisses cleanly, no editor-hover regression; pre-existing link-click limitation noted (not a regression)

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: —

Summary

Review verdict recovered from the session transcript (agent could not run coord report-result).

Verdict: approve

Review findings

Summary

Reviewed issue-478-tui-migrate-sidebar-item-hover-popup-to (2 files changed: src/render.rs, src/tui_main/panels.rs; no other files touched). Per harness policy I did not run cargo build/cargo test/clippy — reviewed via careful static/manual trace instead; the coordinator's separate pre-merge smoke gate should still run the full suite before merge.

This is a clean, well-executed migration that does exactly what the issue asked, no more.

What was verified

1. Shared builder added correctly (render.rs) — markdown_rendered_to_quadraui_lines() and md_links_to_quadraui_rich_text_links() are verbatim extractions of logic that used to live inline in editor_hover_to_quadraui_rich_text(), so the already-converged editor hover path has zero behavior change. New panel_hover_to_quadraui_rich_text() (Option B: sibling builder) sets correct read-only defaults (has_focus: false, selection: None, placement: Below). New PANEL_HOVER_MAX_ROWS mirrors the deleted MAX_HEIGHT.

2. render_panel_hover_popup() rewrite — manual box-drawing/MdStyle dispatch/byte→char link math fully deleted, replaced by the same three-call pattern (build → layout → draw_rich_text_popup) already used by the converged editor path. I hand-traced the width, height, and Below-placement anchor math against both the deleted code and quadraui's rich_text_popup.rs::layout() source — all match exactly (not approximately) across every clamp regime. top_row - 1.0 is computed in f32 so a top_row == 0 case never underflows.

3. Scope discipline — only render.rs/panels.rs touched, no ~/src/quadraui edits, no GTK changes, editor hover path untouched. Textbook adherence to the repo's Platform-Neutrality Rule.

Minor / non-blocking notes

• render_panel_hover_popup()'s doc comment wasn't updated to describe the migration (unlike render_editor_hover_popup()'s). Cosmetic.
• No new unit tests added, but this matches existing precedent — the editor-hover equivalent also has no direct unit test today. Worth a follow-up issue for layout-math regression tests, not a blocker.

Verdict

No correctness, security, or platform-neutrality issues found. Approve.