Skip to content

Hover popup: only first bare URL clickable, rest still unregistered #504

Description

@JDonaghy

Problem

#497 fix landed (PR #503) but only partially works. The first bare URL in the hover popup is clickable, but subsequent bare URLs are still not registered as click targets.

Observed

  • First bare URL in hover content: clickable
  • All other bare URLs: styled as links (correct color) but not clickable

Likely cause

The bare URL detection or link registration logic in src/core/markdown.rs or src/core/engine/panels.rs may be stopping after the first match per line/block, or there's an off-by-one in the span offset tracking that causes subsequent URLs to not get registered in extract_hover_links().

Files to investigate

Repro

  1. Hover a Rust symbol with rich docs containing multiple bare URLs (e.g. Vec, HashMap)
  2. Scroll to see multiple URLs in link color
  3. Click first URL — works
  4. Click any subsequent URL — no response

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinguiUI/rendering

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions