#448-F: GTK tab click (activate/close) dead when only ONE tab group exists

[JDonaghy]

Follow-up to the GTK→ShellApp event-dispatch migration. Parent: #448 (regression from #540). Related: #544, #546, #549, #477.

Summary

With a single tab group open, clicking a tab does not activate it, and clicking the tab's × does not close it. As soon as the layout has two or more tab groups, tab clicks (activate + close) work again.

Repro

1. Open the app with a single tab group (default).
2. Open 2+ files so multiple tabs show in that one group.
3. Click a non-active tab → nothing happens (should activate).
4. Click a tab's × → nothing happens (should close).
5. Split the editor into a second tab group → tab clicks now work in both groups.

Root-cause hint

The single-group vs split-group tab-bar paths diverge, and the single-group branch's hit regions appear not to be computed/registered on the new ShellApp click dispatch:

• src/gtk/click.rs:44 (tab-bar height + click routing)
• render::compute_tab_bar_hit_regions() / cached TabBar layout

#549 tracks unifying the split/single draw-loop duplication; this is the click-side counterpart of the same divergence.

Related

• #448-D: GTK ShellApp migration — click-handling logic largely not working (follow-up bugs from #540) #544 — Migrate GTK event dispatch to ShellApp::handle(UiEvent) #448-D: GTK click-handling logic largely not working
• ShellApp: migrate dialog + context-menu rendering and dismissal (right-click & tab-close broken) #546 — dialog + context-menu rendering & dismissal (right-click & tab-close broken)
• Unify tab-bar draw loop's split-group/single-group duplication (GTK + TUI) #549 — unify tab-bar draw loop's split-group/single-group duplication
• TUI: Use compute_tab_bar_hit_regions() / cached TabBar layout for drag slot bounds #477 — use compute_tab_bar_hit_regions() / cached TabBar layout for hit bounds

Acceptance

Single-group tab activate + close work via mouse; add a TuiDriver/black-box test that opens one group and asserts a tab click changes the active tab and the × closes it.

[JDonaghy]

Coordinator Assignment

Machine: elitebook
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #553: #448-F: GTK tab click (activate/close) dead when only ONE tab group exists

Follow-up to the GTK→ShellApp event-dispatch migration. Parent: #448 (regression from #540). Related: #544, #546, #549, #477.

Summary

With a single tab group open, clicking a tab does not activate it, and clicking the tab's × does not close it. As soon as the layout has two or more tab groups, tab clicks (activate + close) work again.

Repro

1. Open the app with a single tab group (default).
2. Open 2+ files so multiple tabs show in that one group.
3. Click a non-active tab → nothing happens (should activate).
4. Click a tab's × → nothing happens (should close).
5. Split the editor into a second tab group → tab clicks now work in both groups.

Root-cause hint

The single-group vs split-group tab-bar paths diverge, and the single-group branch's hit regions appear not to be computed/registered on the new ShellApp click dispatch:

• src/gtk/click.rs:44 (tab-bar height + click routing)
• render::compute_tab_bar_hit_regions() / cached TabBar layout

#549 tracks unifying the split/single draw-loop duplication; this is the click-side counterpart of the same divergence.

Related

• #448-D: GTK ShellApp migration — click-handling logic largely not working (follow-up bugs from #540) #544 — Migrate GTK event dispatch to ShellApp::handle(UiEvent) #448-D: GTK click-handling logic largely not working
• ShellApp: migrate dialog + context-menu rendering and dismissal (right-click & tab-close broken) #546 — dialog + context-menu rendering & dismissal (right-click & tab-close broken)
• Unify tab-bar draw loop's split-group/single-group duplication (GTK + TUI) #549 — unify tab-bar draw loop's split-group/single-group duplication
• TUI: Use compute_tab_bar_hit_regions() / cached TabBar layout for drag slot bounds #477 — use compute_tab_bar_hit_regions() / cached TabBar layout for hit bounds

Acceptance

Single-group tab activate + close work via mouse; add a TuiDriver/black-box test that opens one group and asserts a tab click changes the active tab and the × closes it.

[JDonaghy]

Coordinator: Assignment Failed

Machine: elitebook
Status: failed
Exit code: —
Duration: —
Log: /home/john/.coord/logs/f5d17a64ca38.log

Error

pull failed for quadraui: git pull --ff-only failed: error: Unable to create '/home/john/src/quadraui/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 14m 38s
Log: /home/john/.coord/logs/b4efa291aca6.log