#448-J: Git Insights extension icon missing from ShellApp activity bar

[JDonaghy]

Follow-up to the GTK→ShellApp event-dispatch migration. Parent: #448. Related: #536, #521.

Summary

In the ShellApp activity bar, the Git Insights extension's icon is missing — the extension registers a display name + icon but nothing renders for it in the activity bar.

Root-cause hint

The git-insights extension is registered with a display name (and icon) at src/core/extensions.rs:337 (name: "git-insights", display_name: "Git Insights"). Its activity-bar icon isn't being fed into the migrated AppShell activity bar — extension-provided activity-bar items are likely handled differently from (or after) built-in panels on the new path.

• Migrate activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — consume quadraui#386 #536 migrates activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — the item-source plumbing there is the likely place extension icons get dropped.
• Check the activity-bar item builder: are extension panels contributing an icon glyph the same way built-in panels do?

Related

• Migrate activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — consume quadraui#386 #536 — migrate activity-bar keyboard nav onto quadraui AppShell
• Issues panel + coordinator extension: host shared quadraui Board (Phase 0, read-only) #521 — Issues panel + coordinator extension: host shared quadraui Board

Acceptance

The Git Insights extension icon renders in the activity bar. Add a black-box/TuiDriver assertion that an extension-registered panel contributes a visible activity-bar icon.

[JDonaghy]

Coordinator Assignment

Machine: dellserver
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #557: #448-J: Git Insights extension icon missing from ShellApp activity bar

Follow-up to the GTK→ShellApp event-dispatch migration. Parent: #448. Related: #536, #521.

Summary

In the ShellApp activity bar, the Git Insights extension's icon is missing — the extension registers a display name + icon but nothing renders for it in the activity bar.

Root-cause hint

The git-insights extension is registered with a display name (and icon) at src/core/extensions.rs:337 (name: "git-insights", display_name: "Git Insights"). Its activity-bar icon isn't being fed into the migrated AppShell activity bar — extension-provided activity-bar items are likely handled differently from (or after) built-in panels on the new path.

• Migrate activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — consume quadraui#386 #536 migrates activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — the item-source plumbing there is the likely place extension icons get dropped.
• Check the activity-bar item builder: are extension panels contributing an icon glyph the same way built-in panels do?

Related

• Migrate activity-bar keyboard nav onto quadraui AppShell (retire hand-rolled toolbar_selected arithmetic) — consume quadraui#386 #536 — migrate activity-bar keyboard nav onto quadraui AppShell
• Issues panel + coordinator extension: host shared quadraui Board (Phase 0, read-only) #521 — Issues panel + coordinator extension: host shared quadraui Board

Acceptance

The Git Insights extension icon renders in the activity bar. Add a black-box/TuiDriver assertion that an extension-registered panel contributes a visible activity-bar icon.

[JDonaghy]

Coordinator: Assignment Failed

Machine: dellserver
Status: failed
Exit code: —
Duration: —
Log: /home/john/.coord/logs/a7f356b2a60c.log

Error

pull failed for quadraui: git pull --ff-only failed: From github.com:JDonaghy/quadraui
659a30a..5a418ca develop -> origin/develop

• [new branch] issue-455-review-modalstack-drives-hit-testing-but -> origin/issue-455-review-modalstack-drives-hit-testing-but
  You are not currently on a branch.
  Please specify which branch you want to merge with.
  See git-pull(1) for details.

  git pull

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 19m 49s
Log: /home/john/.coord/logs/960241aa9242.log

[JDonaghy]

🧊 Pipeline row stalled

Machine: precision
Assignment: 960241aa9242
Issue: #557
Reason: Work done, no review ever dispatched

Work is done with test_state='passed' but no review assignment was ever dispatched for it.

Detection + surfacing only — nothing was dispatched automatically. This row's auto-loop transition already fired once and won't fire again on its own; a human should look at coord status and decide whether to dispatch a fix/review manually or drop it with coord backlog.