#595 Stage 4 — wire remaining TuiShellApp::handle key dispatch (dialog/palette/completion/context-menu + #318 Alt-reveal shim)

[JDonaghy]

Part of epic #595, milestone #9 TUI ShellApp Migration. Stage 4 of the work order. Depends on Stage 1/2.

Goal

Wire the remaining KeyPressed dispatch into TuiShellApp::handle (src/tui_main/shell_app.rs). Today handle only routes plain KeyPressed to Engine::handle_key (already backend-agnostic) plus panel-key accelerators + MenuSystem intercept; everything else returns Reaction::Continue with a // TODO(#595) marker.

Scope

Port the higher-priority key intercepts from event_loop():

• dialog / command-palette / completion-popup / context-menu key handling (the modal intercepts that must consume keys before Engine::handle_key).
• The "TUI: default Alt+letter keybindings clash with menu bar shortcuts #318" Alt+menu-letter "reveal menu bar" shim (mod.rs:1275-:1294) that sits between the accelerator and MenuSystem dispatch layers — sets engine.menu_bar_visible = true on Alt+ so the same keystroke both reveals and activates the menu. Explicitly NOT yet ported (called out in the module doc so it isn't assumed complete).

Acceptance

• Palette/dialog/completion/context-menu keyboard flows work through ShellApp::handle.
• driver_with_shell key-injection assertions covering at least the palette open + Alt-reveal path.

Dependencies

Depends on Stage 1/2. No cross-repo dep. Refs: PLAN.md Stage 4; shell_app.rs module doc (Alt-reveal shim note).

[JDonaghy]

Coordinator: Advisory — Worker Exited With 0 Commits

Machine: elitebook
Status: advisory
Duration: 15m 19s

The worker exited cleanly (exit code 0) but pushed no commits. This typically means the feature was already implemented or no change was needed. Human review is required to decide the next step.

Worker note

Human-attended chat session closed (diagnostic-only — no committed work).

[JDonaghy]

Coordinator Assignment

Machine: dellserver
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #603: #595 Stage 4 — wire remaining TuiShellApp::handle key dispatch (dialog/palette/completion/context-menu + #318 Alt-reveal shim)

Part of epic #595, milestone #9 TUI ShellApp Migration. Stage 4 of the work order. Depends on Stage 1/2.

Goal

Wire the remaining KeyPressed dispatch into TuiShellApp::handle (src/tui_main/shell_app.rs). Today handle only routes plain KeyPressed to Engine::handle_key (already backend-agnostic) plus panel-key accelerators + MenuSystem intercept; everything else returns Reaction::Continue with a // TODO(#595) marker.

Scope

Port the higher-priority key intercepts from event_loop():

• dialog / command-palette / completion-popup / context-menu key handling (the modal intercepts that must consume keys before Engine::handle_key).
• The "TUI: default Alt+letter keybindings clash with menu bar shortcuts #318" Alt+menu-letter "reveal menu bar" shim (mod.rs:1275-:1294) that sits between the accelerator and MenuSystem dispatch layers — sets engine.menu_bar_visible = true on Alt+ so the same keystroke both reveals and activates the menu. Explicitly NOT yet ported (called out in the module doc so it isn't assumed complete).

Acceptance

• Palette/dialog/completion/context-menu keyboard flows work through ShellApp::handle.
• driver_with_shell key-injection assertions covering at least the palette open + Alt-reveal path.

Dependencies

Depends on Stage 1/2. No cross-repo dep. Refs: PLAN.md Stage 4; shell_app.rs module doc (Alt-reveal shim note).

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: 28m 59s
Log: /home/john/.coord/logs/74407dac026f.log