Migrate 7 Tooltip construction sites to quadraui's new builder API (quadraui#541 follow-up)

[JDonaghy]

What

Migrate all 7 quadraui::Tooltip { .. } exhaustive struct-literal construction
sites to the new Tooltip::new(id, text).with_*(..) builder API shipped by
JDonaghy/quadraui#541 (PR JDonaghy/quadraui#608).

Why

quadraui#541 gives Tooltip two new fields (border: TooltipBorder,
title: Option<String>) so a consumer can choose full-box / sides-only / no
border, and adds a title slot. Tooltip stays a plain exhaustive struct (not
#[non_exhaustive]) — see the Downstream impact doc comment on
quadraui::primitives::tooltip — so every exhaustive Tooltip { .. } literal
with no ..Default::default() fails to compile the instant the new fields
land, and this repo has 7 of them:

• src/tui_main/panels.rs:810
• src/render.rs:1151
• src/render.rs:1490
• src/render.rs:4285
• src/gtk/draw.rs:1378
• src/gtk/draw.rs:1667
• src/gtk/draw.rs:1765

quadraui shipped Tooltip::new(id, text) (all other fields at their
behaviour-preserving default) plus .with_styled_lines(), .with_placement(),
.with_border(), .with_title(), .with_bg(), .with_fg() builder methods
specifically so call sites survive the next field addition too — this
migration is a one-time cost, not a recurring one, once done.

Tooltip::new's default border is TooltipBorder::Full, which is defined to
match what every backend already renders on develop today (GTK/macOS have
always stroked a full box; TUI has since #542 whenever height >= 3). So this
migration needs no new .with_border(..) calls to preserve current
on-screen appearance — it's a pure literal→builder rewrite.

Example

Before (src/render.rs:1151):

let tooltip = quadraui::Tooltip {
    id: quadraui::WidgetId::new("lsp_hover"),
    text: hover.text.clone(),
    styled_lines: None,
    placement: quadraui::TooltipPlacement::Top,
    bg: None,
    fg: None,
};

After:

let tooltip = quadraui::Tooltip::new(quadraui::WidgetId::new("lsp_hover"), hover.text.clone())
    .with_placement(quadraui::TooltipPlacement::Top);

Only chain .with_*() for fields that were set to a non-default value; drop
fields that matched the default (styled_lines: None, bg: None, fg: None,
placement: TooltipPlacement::default()).

Acceptance

• All 7 sites use Tooltip::new(..).with_*(..) instead of a raw struct literal.
• No visual change — this is a construction-syntax migration only.
• cargo build && cargo test green once built against quadraui#541's
  branch (cargo update -p quadraui / the repo's local-path override —
  see this repo's own quadraui-pin docs — to build against the unmerged
  branch before it's on develop).

Blocked on

JDonaghy/quadraui#541 / PR JDonaghy/quadraui#608 landing on quadraui's
develop (the new Tooltip::new/with_* API doesn't exist before that).
Can be branched and written ahead of time against the PR branch; final merge
should wait for quadraui#541 to land so CI actually resolves the new API from
develop.

[JDonaghy]

Coordinator Assignment

Machine: precision
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #661: Migrate 7 Tooltip construction sites to quadraui's new builder API (quadraui#541 follow-up)

What

Migrate all 7 quadraui::Tooltip { .. } exhaustive struct-literal construction
sites to the new Tooltip::new(id, text).with_*(..) builder API shipped by
JDonaghy/quadraui#541 (PR JDonaghy/quadraui#608).

Why

quadraui#541 gives Tooltip two new fields (border: TooltipBorder,
title: Option<String>) so a consumer can choose full-box / sides-only / no
border, and adds a title slot. Tooltip stays a plain exhaustive struct (not
#[non_exhaustive]) — see the Downstream impact doc comment on
quadraui::primitives::tooltip — so every exhaustive Tooltip { .. } literal
with no ..Default::default() fails to compile the instant the new fields
land, and this repo has 7 of them:

• src/tui_main/panels.rs:810
• src/render.rs:1151
• src/render.rs:1490
• src/render.rs:4285
• src/gtk/draw.rs:1378
• src/gtk/draw.rs:1667
• src/gtk/draw.rs:1765

quadraui shipped Tooltip::new(id, text) (all other fields at their
behaviour-preserving default) plus .with_styled_lines(), .with_placement(),
.with_border(), .with_title(), .with_bg(), .with_fg() builder methods
specifically so call sites survive the next field addition too — this
migration is a one-time cost, not a recurring one, once done.

Tooltip::new's default border is TooltipBorder::Full, which is defined to
match what every backend already renders on develop today (GTK/macOS have
always stroked a full box; TUI has since #542 whenever height >= 3). So this
migration needs no new .with_border(..) calls to preserve current
on-screen appearance — it's a pure literal→builder rewrite.

Example

Before (src/render.rs:1151):

let tooltip = quadraui::Tooltip {
    id: quadraui::WidgetId::new("lsp_hover"),
    text: hover.text.clone(),
    styled_lines: None,
    placement: quadraui::TooltipPlacement::Top,
    bg: None,
    fg: None,
};

After:

let tooltip = quadraui::Tooltip::new(quadraui::WidgetId::new("lsp_hover"), hover.text.clone())
    .with_placement(quadraui::TooltipPlacement::Top);

Only chain .with_*() for fields that were set to a non-default value; drop
fields that matched the default (styled_lines: None, bg: None, fg: None,
placement: TooltipPlacement::default()).

Acceptance

• All 7 sites use Tooltip::new(..).with_*(..) instead of a raw struct literal.
• No visual change — this is a construction-syntax migration only.
• cargo build && cargo test green once built against quadraui#541's
  branch (cargo update -p quadraui / the repo's local-path override —
  see this repo's own quadraui-pin docs — to build against the unmerged
  branch before it's on develop).

Blocked on

JDonaghy/quadraui#541 / PR JDonaghy/quadraui#608 landing on quadraui's
develop (the new Tooltip::new/with_* API doesn't exist before that).
Can be branched and written ahead of time against the PR branch; final merge
should wait for quadraui#541 to land so CI actually resolves the new API from
develop.

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 11m 4s
Log: /home/john/.coord/logs/ed51e182af7e.log

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 3m 1s
Log: /home/john/.coord/logs/b48e4acf5cf3.log

[JDonaghy]

Coordinator Assignment

Machine: precision
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

You are fixing a failed smoke test for issue #661: Migrate 7 Tooltip construction sites to quadraui's new builder API (quadraui#541 follow-up)

The previous worker created branch issue-661-migrate-7-tooltip-construction-sites-to. You are already on that branch.
Do NOT start over — work from the existing code.

What was done

The previous worker's changes are already committed on this branch.
Run git fetch origin && git log --oneline origin/develop..HEAD to see what was done.
Run git diff origin/develop...HEAD to see the full diff.

Test failure

cargo test fails to compile: 7 sites call quadraui::Tooltip::new(...).with_*(...) but quadraui's Tooltip (pinned f6d27c2, and current develop tip) has no new()/builder API at all -- it's a plain struct built via literal syntax; E0599 x7 in src/gtk/draw.rs, src/render.rs, src/tui_main/panels.rs

Guidance

Fix the failing tests and push.

Rules

• Do NOT start over or rewrite from scratch
• Fix the specific test failures
• Commit your fixes and push with git push origin HEAD

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 6m 39s
Log: /home/john/.coord/logs/6b124c0c49d9.log

[JDonaghy]

Coordinator: Assignment Complete

Machine: elitebook
Status: done
Exit code: 0
Duration: 17m 35s
Log: /home/john/.coord/logs/da1922ca3e94.log

[JDonaghy]

Coordinator Assignment

Machine: precision
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

You are fixing a failed smoke test for issue #661: Migrate 7 Tooltip construction sites to quadraui's new builder API (quadraui#541 follow-up)

The previous worker created branch issue-661-migrate-7-tooltip-construction-sites-to. You are already on that branch.
Do NOT start over — work from the existing code.

What was done

The previous worker's changes are already committed on this branch.
Run git fetch origin && git log --oneline origin/develop..HEAD to see what was done.
Run git diff origin/develop...HEAD to see the full diff.

Test failure

1/2256 tests failed: tab_hit_regions_match_painted_columns_for_wide_names — pre-existing on merge-base 8148828, unrelated to Tooltip changes

Guidance

Fix the failing tests and push.

Rules

• Do NOT start over or rewrite from scratch
• Fix the specific test failures
• Commit your fixes and push with git push origin HEAD

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 4m 51s
Log: /home/john/.coord/logs/79552bf85091.log

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 3m 17s
Log: /home/john/.coord/logs/90888dabc16e.log