Converge keyboard dispatch slice 3: terminal / PTY key routing (#351)

[JDonaghy]

Continuation of #734, slice 3 of 7. #734 declared a 7-slice plan and was
closed when slice 1's PR merged — the remaining slices were never filed. This issue is
one of them. Measured on develop @ 44882e9 (2026-09-02):

handle_key_press (src/gtk/mod.rs) 274 ·
dispatch_gtk_panel_accelerator 80 · handle_key_pressed (src/tui_main/shell_app.rs)
604 · handle_sidebar_focused_key 442 · dispatch_panel_accelerator_sizeless 120
— 1,520 lines total, against the 1,622 #734 was filed on. 13 of the 19
mirrors mod.rs:NNNN comments survive, and every surviving reference is still wrong.

Locate everything below by symbol, not by line number — #734's own body warns that
its numbers drift, and they already have.

The rung

TUI: ── Terminal (PTY) key routing (#351, mirrors mod.rs:2439-:2513) ── in
handle_key_pressed. The cited GTK lines now land on | Msg::OpenWorkspaceDialog — a match
arm in a dispatch that #732 has since deleted outright. The pointer is not merely stale;
its target no longer exists.

GTK's twin lives in handle_key_press, and the two disagree about which keys are forwarded
to the PTY versus handled by the app. #471 (typing in the right pane of a split terminal
makes text in that pane disappear) is a live GTK-only bug in this rung.

Adjacent, and in scope because they are the same decision: ── Bracketed paste (mirrors mod.rs:3032-:3035) ── and ── Resize → PTY resize (mirrors mod.rs:3036-:3045) ──
(shell_app.rs) — both carry stale pointers to the same deleted function.

Note

TerminalSession (quadraui) owns the encoder question — see quadraui#342 ("lift the
keyboard/mouse → PTY encoder out of the example into the engine") and quadraui#343
(bracketed-paste as an input-readiness signal). Check quadraui first (CLAUDE.md): if
the encoder belongs upstream, this slice becomes an adoption issue and the shared half is a
thin render::route_terminal_key. Say which it is in the PR.

Acceptance criteria

Inherited verbatim from #734 — these are the rules that make a slice done:

• The rung is implemented once, in shared code (src/render.rs), and called from both
  backends.
• Both backends' bespoke arms for that rung are deleted in the same PR. A migration that
  leaves both paths is not done (GOALS.md, "How to use this doc").
• Black-box coverage on both backends — TuiDriver via driver_with_shell(TuiShellApp, …)
  in src/tui_main/shell_app.rs, and GtkDriver in src/gtk/testing.rs. Assert on rendered
  output, never on state being populated (CLAUDE.md rule 1).
• The PR states the new tests were verified RED against unfixed develop (CLAUDE.md rule 2).
• Combined production line count of the entry points above strictly decreases; the PR states
  before/after. (Converge the two mouse routers — ~4,800 lines implementing the same precedence ladder twice #733 slice 1 met this only barely — 4,994 → 4,861 — and Converge frame composition — ~4,500 lines laying down the same surfaces in two hand-kept orders #735 slice 1 did not
  meet it at all. State the numbers.)
• cargo build && cargo test && cargo clippy -- -D warnings && cargo fmt --check EXIT=0.

Scope discipline

This is one slice. Do not attempt the rungs belonging to the sibling issues listed in
Sequencing — they conflict in the same files and are queued behind this one on purpose.

Files

• src/render.rs (the shared router)
• src/tui_main/shell_app.rs
• src/gtk/mod.rs
• src/gtk/testing.rs (GtkDriver coverage)

Sequencing

After slice 2 (focus owners) — terminal focus sits inside the focus ladder that slice
rewrites.

Relates: #351, #471, quadraui#342, quadraui#343.

Milestone

#7 Platform-Neutral

[JDonaghy]

Coordinator Assignment

Machine: dellserver
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #758: Converge keyboard dispatch slice 3: terminal / PTY key routing (#351)

Continuation of #734, slice 3 of 7. #734 declared a 7-slice plan and was
closed when slice 1's PR merged — the remaining slices were never filed. This issue is
one of them. Measured on develop @ 44882e9 (2026-09-02):

handle_key_press (src/gtk/mod.rs) 274 ·
dispatch_gtk_panel_accelerator 80 · handle_key_pressed (src/tui_main/shell_app.rs)
604 · handle_sidebar_focused_key 442 · dispatch_panel_accelerator_sizeless 120
— 1,520 lines total, against the 1,622 #734 was filed on. 13 of the 19
mirrors mod.rs:NNNN comments survive, and every surviving reference is still wrong.

Locate everything below by symbol, not by line number — #734's own body warns that
its numbers drift, and they already have.

The rung

TUI: ── Terminal (PTY) key routing (#351, mirrors mod.rs:2439-:2513) ── in
handle_key_pressed. The cited GTK lines now land on | Msg::OpenWorkspaceDialog — a match
arm in a dispatch that #732 has since deleted outright. The pointer is not merely stale;
its target no longer exists.

GTK's twin lives in handle_key_press, and the two disagree about which keys are forwarded
to the PTY versus handled by the app. #471 (typing in the right pane of a split terminal
makes text in that pane disappear) is a live GTK-only bug in this rung.

Adjacent, and in scope because they are the same decision: ── Bracketed paste (mirrors mod.rs:3032-:3035) ── and ── Resize → PTY resize (mirrors mod.rs:3036-:3045) ──
(shell_app.rs) — both carry stale pointers to the same deleted function.

Note

TerminalSession (quadraui) owns the encoder question — see quadraui#342 ("lift the
keyboard/mouse → PTY encoder out of the example into the engine") and quadraui#343
(bracketed-paste as an input-readiness signal). Check quadraui first (CLAUDE.md): if
the encoder belongs upstream, this slice becomes an adoption issue and the shared half is a
thin render::route_terminal_key. Say which it is in the PR.

Acceptance criteria

Inherited verbatim from #734 — these are the rules that make a slice done:

• The rung is implemented once, in shared code (src/render.rs), and called from both
  backends.
• Both backends' bespoke arms for that rung are deleted in the same PR. A migration that
  leaves both paths is not done (GOALS.md, "How to use this doc").
• Black-box coverage on both backends — TuiDriver via driver_with_shell(TuiShellApp, …)
  in src/tui_main/shell_app.rs, and GtkDriver in src/gtk/testing.rs. Assert on rendered
  output, never on state being populated (CLAUDE.md rule 1).
• The PR states the new tests were verified RED against unfixed develop (CLAUDE.md rule 2).
• Combined production line count of the entry points above strictly decreases; the PR states
  before/after. (Converge the two mouse routers — ~4,800 lines implementing the same precedence ladder twice #733 slice 1 met this only barely — 4,994 → 4,861 — and Converge frame composition — ~4,500 lines laying down the same surfaces in two hand-kept orders #735 slice 1 did not
  meet it at all. State the numbers.)
• cargo build && cargo test && cargo clippy -- -D warnings && cargo fmt --check EXIT=0.

Scope discipline

This is one slice. Do not attempt the rungs belonging to the sibling issues listed in
Sequencing — they conflict in the same files and are queued behind this one on purpose.

Files

• src/render.rs (the shared router)
• src/tui_main/shell_app.rs
• src/gtk/mod.rs
• src/gtk/testing.rs (GtkDriver coverage)

Sequencing

After slice 2 (focus owners) — terminal focus sits inside the focus ladder that slice
rewrites.

Relates: #351, #471, quadraui#342, quadraui#343.

Milestone

#7 Platform-Neutral

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: 28m 49s
Log: /home/john/.coord/logs/9b1904d57840.log

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: 4m 41s
Log: /home/john/.coord/logs/0f709434c7e0.log

[JDonaghy]

Coordinator Assignment

Machine: dellserver
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

You are fixing a failed smoke test for issue #758: Converge keyboard dispatch slice 3: terminal / PTY key routing (#351)

The previous worker created branch issue-758-converge-keyboard-dispatch-slice-3-termi. You are already on that branch.
Do NOT start over — work from the existing code.

What was done

The previous worker's changes are already committed on this branch.
Run git fetch origin && git log --oneline origin/develop..HEAD to see what was done.
Run git diff origin/develop...HEAD to see the full diff.

Test failure

cargo test: 1 failed (tui_main::shell_app::tests::tui_editor_text_drag_paints_a_selection_through_the_shared_drag_router — drag repaint assertion, both probes same non-selection style)

Guidance

Fix the failing tests and push.

Rules

• Do NOT start over or rewrite from scratch
• Fix the specific test failures
• Commit your fixes and push with git push origin HEAD

[JDonaghy]

Coordinator: Assignment Complete

Machine: dellserver
Status: done
Exit code: 0
Duration: 23m 53s
Log: /home/john/.coord/logs/704bd98921b9.log