feat: migrate menu bar labels to quadraui::MenuBar (#301) - #309
Merged
Conversation
Replace bespoke per-backend menu label paint + click/hover with quadraui::MenuBar in both TUI and GTK. Menu labels now paint through quadraui rasterisers; click and hover use cached MenuBarLayout::hit_test instead of hand-rolled geometry. Nav arrows + search box remain as-is pending quadraui#51 (CommandCenter primitive). Closes #301 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_menu_bar) and GTK (draw_menu_bar) withquadraui::tui::draw_menu_bar()/quadraui::gtk::draw_menu_bar()7px/char + 10pxapproximation) and GTK hover-to-switch withMenuBarLayout::hit_test()from cached paint layoutrender::build_menu_bar_view()adapter that convertsMENU_STRUCTURE+engine.menu_open_idxinto aquadraui::MenuBardescriptorMenuBarLayouton engine at paint time (established pattern from Lift terminal panel toolbar to quadraui primitives (StatusBar + TabBar) #305)What stays
Nav arrows (◀ ▶) + search/title box rendering and click handling remain as bespoke per-backend code pending quadraui#51 (CommandCenter primitive). Pre-existing dispatch gaps (GTK arrow keys, TUI Alt conflicts, TUI hover) tracked in #308.
Test plan
cargo fmt— cleancargo clippy -- -D warnings— zero warningscargo test --no-default-features— 4,907 tests pass (1952 lib + 2040 integration)cargo build— compilesCloses #301
🤖 Generated with Claude Code