Skip to content

fix: re-add ..Default::default() to ContextMenuItem literals - #432

Merged
JDonaghy merged 1 commit into
developfrom
fix-context-menu-item-defaults
May 16, 2026
Merged

fix: re-add ..Default::default() to ContextMenuItem literals#432
JDonaghy merged 1 commit into
developfrom
fix-context-menu-item-defaults

Conversation

@JDonaghy

Copy link
Copy Markdown
Owner

Summary

  • Commit `8a53307` (merged via PR feat: cache bottom-panel geometry; resolve_bottom_panel_zone (#418) #424) removed the `..Default::default()` lines on four `quadraui::ContextMenuItem` literals in `src/render.rs` that `a516f76` had added to keep develop compiling against the newer quadraui field shape (`checked`, `key_equivalent`, `submenu` added in quadraui `daed293`).
  • Without these lines, develop fails to build with E0063 — confirmed locally on a fresh checkout.
  • This PR re-applies the same 4-line fix. No behavior change; the doc on `ContextMenuItem` explicitly recommends struct-update syntax for forward compat.

Test plan

  • `cargo build` — clean
  • `cargo clippy -- -D warnings` — no warnings
  • `cargo test --no-default-features --lib` — 1963 passed / 0 failed

Discovered while smoke-testing PR #427 (action menu migration). #427 will be rebased onto develop once this lands.

🤖 Generated with Claude Code

Commit 8a53307 (PR #424) removed the ..Default::default() lines that
a516f76 had added to unblock CI for the quadraui ContextMenuItem field
bump. develop no longer compiles without them. Re-applies the same
4-line fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@JDonaghy
JDonaghy merged commit 1256fcb into develop May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant