#508: Adopt quadraui TUI text-selection + OSC52 clipboard; delete bespoke clipboard/selection plumbing - #566
Merged
JDonaghy merged 1 commit intoJul 9, 2026
Conversation
Deletes the bespoke xclip/xsel/wl-copy/wl-paste process-spawning clipboard plumbing (find_clipboard_write_cmd/find_clipboard_read_cmd/has_binary), the DISPLAY=:0 hack, and the stderr-suppression RAII guard that existed only to hide "Can't open display" noise from those spawns. quadraui#269 + #283 (both merged) now ship TuiPlatformServices, which covers the same ground upstream: arboard for the local desktop clipboard, OSC 52 (stdout + /dev/tty, with tmux DCS passthrough) for SSH/tmux, and a native clipboard-tool fallback leg for local-X11-inside-tmux. setup_tui_clipboard now just wraps a shared TuiPlatformServices in two Fn closures matching the engine's existing clipboard_read/clipboard_write callback shape. Scoped to part 1 of #508 (the clipboard swap — high confidence per the issue). Parts 2 (terminal-panel TextRegion migration) and 3 (editor visual-selection drag-arbitration migration) are deferred to follow-up issues; findings recorded via `coord context` on #508. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #508
Automated merge from the coordinator for assignment 8c2735dbc726 on issue #508.
Worker branch:
issue-508-adopt-quadraui-tui-text-selection-osc52→develop.