#565: Route editor visual-selection drag through quadraui DragTarget::TextSelection (#508 part 3) - #569
Merged
JDonaghy merged 1 commit intoJul 10, 2026
Conversation
…h quadraui DragTarget::TextSelection Arms a DragTarget::TextSelection (region encoding the origin window id, following the tui:editor:<id>:vsb/hsb scrollbar convention) at mouse-down on an editor text area. The Drag(Left) handler now recovers the drag's origin window from drag_state instead of the old bespoke mouse_text_drag bool, and uses it to ignore drag events that cross into another split before calling engine.mouse_drag — removing the mouse_text_drag bool and its plumbing entirely. The document-model hit-testing (window_zone_hit_test -> buf_line/col -> engine.mouse_drag) and the engine's own mouse_drag_origin_window guard are unchanged, kept as defense-in-depth (also covered directly by test_mouse_drag_locked_to_origin_window, which calls engine.mouse_drag without going through mouse.rs). Adds unit tests for the new widget-id encode/decode helpers since handle_mouse itself has no test harness in this codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #565
Automated merge from the coordinator for assignment a9dfe980c91d on issue #565.
Worker branch:
issue-565-route-editor-visual-selection-drag-throu→develop.