#572: GTK: route gtk4::FileDialog calls through PlatformServices (Stage G of #493) - #586
Merged
JDonaghy merged 1 commit intoJul 17, 2026
Conversation
…mServices Msg::OpenFileDialog and Msg::SaveWorkspaceAsDialog now call backend.services().show_file_open_dialog()/show_file_save_dialog() (quadraui#427, now shipped) instead of constructing gtk4::FileDialog in-line. dispatch() has no `backend` in scope, so the request is stashed in a new PendingFileDialog Cell and drained in tick(), which does receive the runner-owned `backend: &mut dyn quadraui::Backend` — the same instance whose PlatformServices pump_depth is wired to the runner's own event controllers, unlike App's separate self.backend field (used for modal-stack/drag-state), which must NOT be used for this (unshared pump_depth would reintroduce the #427 double-borrow panic). Msg::OpenFolderDialog stays on direct gtk4::FileDialog for now: quadraui::PlatformServices has no folder-select dialog mode yet (only file-open/file-save). That gap needs a new quadraui issue before the third call site can migrate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #572
Automated merge from the coordinator for assignment 7f7bcbceb149 on issue #572.
Worker branch:
issue-572-gtk-route-gtk4-filedialog-calls-through→develop.