#604: #595 Stage 5 — apply editor cursor placement on the TUI ShellApp path (consume quadraui#466) - #626
Merged
JDonaghy merged 1 commit intoAug 6, 2026
Conversation
…path quadraui#466 (already landed upstream) closed gap 3 generically: TuiBackend caches draw_editor's cursor_position unconditionally, and render_frame (shared by the live runner, run_with_shell, and TuiDriver) applies it to the real Frame after render_content returns — the same way apply_selection_highlight already does. No vimcode production code change was needed since render_window's local frame: None no longer means "no cursor". Adds insert_mode_bar_cursor_reaches_terminal_frame_via_shell_app, a driver_with_shell test asserting the Bar cursor painted by typing through TuiShellApp actually reaches TestBackend's terminal cursor position, and updates the module doc to mark gap 3 closed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604
Automated PR opened by coordinator for review of issue #604.