#676: GTK: the VS Code-style Command Center (nav arrows + search box) was dropped by the #540 Relm4→ShellApp cutover and never re-wired - #689
Merged
JDonaghy merged 1 commit intoAug 28, 2026
Conversation
The #540 Relm4->ShellApp cutover deleted the titlebar draw closure that called quadraui::gtk::draw_command_center and its click handler, but the replacement ShellApp::render_content/handle never ported either half. The inline window-control buttons (min/max/close) were handed the entire menu_end..right-edge band and background-filled it end-to-end, silently claiming the space the Command Center used to live in. - render_content: narrow the window-controls rect to the buttons' actual measured width (via Backend::status_bar_layout), paint render::build_command_center_view/Backend::draw_command_center in the freed gap after menu_system.render() (load-bearing order, matches the #552 window-controls hazard), and cache the result into engine.command_center_layout, clearing it when the menu bar is hidden. - handle(): hit-test command_center_layout on MouseDown, before the window-controls check and the CSD drag-to-move fallback, dispatching the dormant (never-called-since-#540) Msg::MruNavBack / Msg::MruNavForward / Msg::OpenCommandCenter. - Delete the dead menu_bar_da field (never assigned Some since the cutover) and its four dead reads. - Add a black-box GTK test module asserting painted pixels (not text) for the arrows/search box, no overlap with the window controls, and that clicks route to tab-nav / the picker. PROJECT_STATE.md:92 already lists the Command Center as done on both backends; no further doc edit needed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676
Automated PR opened by coordinator for review of issue #676.