#710: GTK VS Code parity: menu dropdown paints in the editor font, not the menu-bar UI font; command-centre row is one editor line tall - #711
Merged
JDonaghy merged 1 commit intoAug 31, 2026
Conversation
…e parity Item 1 — bump the quadraui pin (Cargo.toml, Cargo.lock) to 227a8c42aca08a421c55b603f303a943a78edfe7, which lands quadraui#637: GtkBackend::draw_context_menu and ::draw_command_center now save/set/ restore ui_font around their rasteriser calls, mirroring draw_menu_bar's existing #624 fix. Before this, the open Edit-menu dropdown inherited whatever font a previous paint call left on the frame's shared Pango layout (the editor font) while the bar directly above it already painted in the UI font, in the same click. Item 2 — bump build_shell_config's with_title_bar multiplier from 1.0 to 1.7 (src/gtk/mod.rs). The title-bar/menu-row band is an editor-line-height multiple with no fixed-px reservation API yet, so this is the only knob available; 1.0 measured ~18px band / ~14px pill in the headless harness (one editor text line), 1.7 measures ~31px / ~27px — much closer to VS Code's 35px title bar / ~26px pill. The residual (still lh-coupled, not fixed-px) is noted inline; a quadraui px-based reservation issue was not filed as part of this PR — flagging for the reviewer to decide if it's needed now or can wait alongside #699 Tier 1's similar asks. Tests (src/gtk/testing.rs, GtkDriver): both new tests verified red against the unfixed state (pre-#637 pin / with_title_bar(1.0)) before being restored to pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #710
Automated merge from the coordinator for assignment d96230ecfffb on issue #710.
Worker branch:
issue-710-gtk-vs-code-parity-menu-dropdown-paints→develop.