#811: Bump quadraui pin to HEAD (42 commits) and fix the 4 removed-API call sites — next bump does not compile - #837
Merged
JDonaghy merged 1 commit intoSep 5, 2026
Conversation
quadraui#704 removed `Backend::drag_and_modal_mut` (and `modal_stack_mut`) in favour of `drag_state_handle()` / `modal_stack_handle()`, which return `Rc<RefCell<_>>`. vimcode still called the removed method at four sites in `src/tui_main/shell_app.rs`, so the next pin bump would not have compiled. - Rewrite the four call sites against the handle API. The simultaneous `&mut DragState` + `&mut ModalStack` borrow that `drag_and_modal_mut` existed to provide now falls out of `borrow_mut()`ing two independent handles. - Release the two `RefMut` guards explicitly after `mouse::handle_mouse`, alongside the existing `drop()` block, so later code touching the backend's drag/modal state cannot double-borrow. - Refresh the four stale module/inline doc references to quadraui#467's `drag_and_modal_mut`. - Bump both `rev` entries in `Cargo.toml` (the `quadraui` dependency and the `[patch.crates-io] vt100` entry) to `4ff2a645023637bba7229e0aeee5968a9c6f3652`; `Cargo.lock` relocked. `vcd --version` now reports `VimCode 0.10.0 (quadraui 4ff2a6450236)`. Pure refactor + dependency bump: no user-visible behaviour change, so no new black-box test is required per CLAUDE.md's acceptance bar. The existing `#[cfg(test)]` shell_app modal-gating tests (`modal_blocks_event_skips_explorer_intercept_when_modal_covers_click` and its context-menu companion) already drive the rewritten code paths and were ported to the handle API in place. Closes #811 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #811
Automated PR opened by coordinator for review of issue #811.