Fail a CPU blit whose source format cannot be converted - #13
Open
f1nalspace wants to merge 1 commit into
Open
f1nalspace wants to merge 1 commit into
f1nalspace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
surface_cpu_blt()needs a format conversion andsurface_convert_format()has noconverter for it, it logs "Cannot convert source surface format to dest format." and jumps
to
release:without settinghr, which is stillWINED3D_OKfrom its initialization.The caller reports success although nothing was copied.
This sets
WINED3DERR_NOTAVAILABLEat that point, like the other unsupported cases in thesame function.
Found while tracking down black DXT1 textures in Descent 3 (see the DXT1 PR). On its own it
does not change what that game shows — Descent 3 ignores the return value of
Blt()— butan application that checks it now sees the failure.
Tested: built on
mainwith the MinGW cross toolchain. Not run on its own.