fix(rsdwserver): clear merge blockers on upstream PR #4921 - #1
Draft
JSaterdalen wants to merge 3 commits into
Draft
JSaterdalen wants to merge 3 commits into
JSaterdalen wants to merge 3 commits into
Conversation
serverlist-validate.sh requires every distro dependency CSV to carry one row per entry in serverlist.csv. Adding rsdw to serverlist.csv without the matching rows left all 23 CSVs at 140 rows against 141 servers, which fails the check once it runs on develop. RuneScape: Dragonwilds is a UE5 server needing no packages beyond the common and steamcmd sets, so each row is a bare shortname, matching the other UE5 servers (pw, sf, ti). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY8uwjiK9JR8ZUdw6XtgXx
rsdw was listed in the ports_edit_array for games whose port is set in
the game config file, so details reported DedicatedServer.ini as the
place to change the port. The port is passed on the command line via
startparameters="-Port=${port} -log", so it is set in the LinuxGSM
config instead.
Move rsdw to the start parameters array so the location resolves to
${configdirserver}.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QY8uwjiK9JR8ZUdw6XtgXx
rsdw had no branch in install_config.sh, so despite _default.cfg setting servercfgdefault="DedicatedServer.ini" nothing ever fetched or copied it and the Config Locations section was never printed. Users had to create the file by hand before the server would finish starting, since OwnerId must be set for initialisation to complete. Requires GameServerManagers/Game-Server-Configs to carry rsdw/DedicatedServer.ini first: fn_fetch_file calls core_exit.sh on a 404, so merging this ahead of the config would break rsdwserver install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY8uwjiK9JR8ZUdw6XtgXx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on
feat/rsdwserverto clear blockers identified on upstream PR GameServerManagers#4921. Merge this intofeat/rsdwserverand it flows into GameServerManagers#4921.Type of change
1.
rsdwmissing from all 23 distro dependency CSVs.github/scripts/serverlist-validate.shrequires eachubuntu*/debian*/centos*/rhel*/almalinux*/rocky*.csvto have the same row count asserverlist.csv. The branch hadserverlist.csvat 141 and every distro CSV at 140, so the check fails on all 23 files.This does not show red on GameServerManagers#4921 — every workflow is gated on
if: github.repository_owner == 'GameServerManagers'and triggers onpush, notpull_request, so none of them run on a fork PR. It would have brokendevelopafter merge.Added a bare
rsdwrow betweenroandrtcwin each file, matching the other UE5 servers (pw,sf,ti), which need no packages beyond the common and steamcmd sets.2. Port edit location pointed at the wrong file
rsdwwas in theports_edit_arrayfor games whose port lives in the game config, sodetailstold users to change the port inDedicatedServer.ini. The config setsstartparameters="-Port=${port} -log", so the port comes from the LinuxGSM config. Movedrsdwto the start parameters array, resolving to${configdirserver}.This is the finding Copilot raised on GameServerManagers#4921.
3.
DedicatedServer.iniwas never installed_default.cfgsetsservercfgdefault="DedicatedServer.ini", butrsdwhad no branch ininstall_config.sh, sofn_default_config_remoteandfn_list_config_locationsnever ran. Nothing created the ini and the Config Locations section never printed — which is why RyanKC4 hit "must setOwnerIdinDedicatedServer.inibefore the server fully starts" on GameServerManagers#4921.Added the dispatch branch.
Ordering dependency — read before merging GameServerManagers#4921
Change 3 requires
rsdw/DedicatedServer.inito exist inGameServerManagers/Game-Server-Configsfirst.fn_fetch_filecallscore_exit.shon a 404 (lgsm/modules/core_dl.sh:406), so merging ahead of the config would hard-failrsdwserver install.The config should be the server-generated
DedicatedServer.iniwith two placeholders thatfn_set_config_varssubstitutes on install:ServerName=SERVERNAMEAdminPassword=ADMINPASSWORDfn_info_game_inimatches keys at line start and ignores sections, so the section header just needs to be whatever the game actually writes.Still outstanding on GameServerManagers#4921 (not addressed here)
lgsm/data/gameicons/rsdw-icon.pngis missing.serverlist-validate-game-icons.sherrors per-server and on the count (140 icons vs 141 servers). Needs the real 32×32 Steam app icon for appid 4019830 — the sandbox proxy blocks Steam's CDN, and a placeholder seemed worse than leaving it visible.rsdwserver.Testing
datadir=lgsm/data bash .github/scripts/serverlist-validate.sh— passes, exit 0, all 23 CSVs at 141.bash -noninfo_messages.shandinstall_config.sh— clean.fn_info_messages_ports_editwithshortname=rsdw— resolves to${configdirserver}instead of the ini path.Risk and rollback
rsdwonly. Theinstall_config.shchange is inert for every other shortname.Breaking changes
Documentation impact
A
rsdwserverpage is still needed at https://github.com/GameServerManagers/LinuxGSM-Docs.🤖 Generated with Claude Code
https://claude.ai/code/session_01QY8uwjiK9JR8ZUdw6XtgXx
Generated by Claude Code