Skip to content

Feature Request: Add an offset to logic of onMenuScrollToBottom #1530

Closed

Description

@omriavigdor

I suggest exposing a prop to the user to set a pixel-offset for when onMenuScrollToBottom is called.
Meaning, suppose I want it to fire 20 pixels before the user scrolls to the bottom of the menu, then I set:
menuScrollToBottomOffset={20}

It will be very helpful if I can do my logic before the user gets to the bottom because if they do it fast enough the whole page is scrolled down (my case is implementing infinite scroll).

Activity

  1. brayhoward commented on Sep 11, 2019

    @brayhoward

    Would pay money for this feature, literally

  2. added
    pr/priorityPRs that should be addressed sooner rather than later
    and removed
    pr/priorityPRs that should be addressed sooner rather than later
    on May 29, 2020
  3. added
    issue/has-prIssue has a PR attached to it that may solve the issue
    on Jul 7, 2020
  4. changed the title [-]Add an offset to logic of onMenuScrollToBottom[/-] [+]Feature Request: Add an offset to logic of onMenuScrollToBottom[/+] on Feb 5, 2021
  5. added
    menu-bugAddresses menu positioning, scrolling, or general interactions
    on Jun 9, 2021
  6. lukebennett88 commented on Oct 27, 2022

    @lukebennett88
    Collaborator

    Thanks for opening this issue.
    In an effort to stay on top of open issues, we're moving feature requests to discussions.

  7. Repository owner locked and limited conversation to collaborators on Oct 27, 2022
  8. converted this issue into a discussion #5437 on Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/has-prIssue has a PR attached to it that may solve the issueissue/reviewedIssue has recently been reviewed (mid-2020)menu-bugAddresses menu positioning, scrolling, or general interactions

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions