onMenuOpen triggers on each input #3335

Activity

1. ronjouch commented on Feb 19, 2019

   

   ronjouch

   on Feb 19, 2019

   Last edited by ronjouch

   More actions

   When a select (or creatable) is open, writing triggers onMenuOpen callback on each keystroke.

   Demo: https://codesandbox.io/s/k0l8r2z6yr

   I think that it should only trigger when opening the menu, right?

   I confirm the bug with react-select@2.4.1 in Chrome 72
2. Bryze commented on Feb 20, 2019

   

   Bryze

   on Feb 20, 2019

   More actions

   Any update on this?
3. viniciusdacal commented on Jul 11, 2019

   

   viniciusdacal

   on Jul 11, 2019

   More actions

   still on 3.0.4.

   The Select component is calling parent props onMenuOpen.
   I imagine that's because the expected behaviour is that the menu should be always open
   if the user is typing.
   However, we could put a condition in the manger, or in the select, if the menu is already open, there's no reason to fire onMenuOpen again.

   👍React with 👍3Reacted by Luis Oliveira, sally-ellevation and hung1998pro
4. lorisdev commented on Jan 7, 2020

   

   lorisdev

   on Jan 7, 2020

   Contributor

   More actions

   Still the same behavior in 3.0.8

   The onMenuOpen callback is triggered within handleInputChange in addition of being triggered already when the Menu actually opens in the openMenu method as is has been mentioned in #3620 as well

   react-select/packages/react-select/src/Select.js

   Line 1092 in 3c7de0d

   this.onMenuOpen();

   react-select/packages/react-select/src/Select.js

   Line 502 in 3c7de0d

   this.onMenuOpen();
5. lorisdev

   added a commit that references this issue on Jan 7, 2020

   Fixes JedWatson#3335 - remove the call to onMenuOpen within handleInp…

   ...

   This issue will close once commit 539b259 is merged into the 'master' branch.

   539b259
6. lorisdev commented on Jan 8, 2020

   

   lorisdev

   on Jan 8, 2020

   Contributor

   More actions

   Well just removing the call to onMenuOpen inside handleInputChange breaks some tests ... Looks like the lib is relying on this buggy behaviour for a reason I don't have time to investigate ...
   Thus it may be a breaking change for many users and may require a major new version...

   😕React with 😕3Reacted by Luca Maroni, Gonzalo Arrivi and twgraham
7. pruik

   added a commit that references this issue on Feb 25, 2020

   - Fixed performance drain with closeMenuOnScroll when using multiple …

   ...

   6f781b2
8. lorisdev

   added a commit that references this issue on Feb 26, 2020

   Fixes JedWatson#3335 - remove the call to onMenuOpen within handleInp…

   ...

   This issue will close once commit 4750e35 is merged into the 'master' branch.

   4750e35
9. lorisdev commented on Feb 26, 2020

   

   lorisdev

   on Feb 26, 2020

   Contributor

   More actions

   pruik found that we should call onMenuOpen inside handleInputChange #3897 (comment)

   The PR now passes all the test 🎉
   He proposed another PR as well which fixes this bug. We may see it fixed soon 🤞
10. bladey

    added

    issue/bug-unconfirmedIssues that describe a bug that hasn't been confirmed by a maintainer yetIssues that describe a bug that hasn't been confirmed by a maintainer yet

    on Jun 3, 2020
11. bladey

    added

    issue/bug-confirmedIssues about a bug that has been confirmed by a maintainerIssues about a bug that has been confirmed by a maintainer

    and removed

    issue/bug-unconfirmedIssues that describe a bug that hasn't been confirmed by a maintainer yetIssues that describe a bug that hasn't been confirmed by a maintainer yet

    on Jun 12, 2020
12. bladey

    linked a pull request that will close this issueFixes #3335 - removes the call to onMenuOpen within handleInputChange #3897on Jun 12, 2020
13. bladey commented on Jun 12, 2020

    

    bladey

    on Jun 12, 2020

    Contributor

    More actions

    PR #3335 in review.
14. bladey

    added

    pr/in-reviewPRs currently in review by maintainers for the next releasePRs currently in review by maintainers for the next release

    issue/reviewedIssue has recently been reviewed (mid-2020)Issue has recently been reviewed (mid-2020)

    and removed

    pr/in-reviewPRs currently in review by maintainers for the next releasePRs currently in review by maintainers for the next release

    on Jun 12, 2020
15. bladey

    added

    issue/has-prIssue has a PR attached to it that may solve the issueIssue has a PR attached to it that may solve the issue

    on Jul 6, 2020
16. JedWatson

    closed this as completedin #3897on Aug 27, 2020
17. JedWatson

    added a commit that references this issue on Aug 27, 2020

    Merge pull request #3897 from lorisdev/fix/3335

    ...

    This issue will close once commit fc7374c is merged into the 'master' branch.

    fc7374c