Repository navigation
[v3.0.5] Old life cycle warning - AutosizeInput #3773
Description
I'm aware that this is an active issue that many users are aware of. However, from what I read it looks like one last warning got swept under the carpet while celebrating the release of 3.0.5. Which by the way, thank you for this, it cleared up a TON of warnings in my Unit Tests.
However... there is one last warning that wasn't taken care of. It occurs in the AutosizeInput component and it uses "componentWillReceiveProps" This is the last warning that is clogging my tests and my console in my dev tools. I would really love to see a fix for this.
Again thanks for everything you've done thus far, I'm very grateful. Here's what my console says:
console.warn node_modules/react-dom/cjs/react-dom.development.js:11494
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: AutosizeInput
Reacted by Julien Genestoux, Dustin Kane, James Lemire, jkeruzec, Julian Garcia Castillo and R1
Reacted by jkeruzec
Activity
[-][v3.0.5] Old life cycle warning[/-][+][v3.0.5] Old life cycle warning - AutosizeInput[/+]mpopv commentedon Sep 23, 2019
Duplicate of #3720
julien51 commentedon Sep 23, 2019
This is not quite a duplicate and more like a regression as this issue #3720 should have indeed been fixed by the
3.0.5?ranneyd commentedon Sep 23, 2019
JedWatson/react-input-autosize#166
gwyneplaine commentedon Sep 24, 2019
@devlemire I don't have publishing rights to react-input-autosize, but I'll have a chat with @JedWatson to get this sorted ASAP, thanks for bringing this to our attention
devlemire commentedon Sep 24, 2019
Thank you for your time!
ranneyd commentedon Sep 24, 2019
Gonna drop this guy here, since it's necessary for getting this lib fixed.
JedWatson/react-input-autosize#167
ranneyd commentedon Sep 25, 2019
#3720 (comment)
devlemire commentedon Sep 27, 2019
@gwyneplaine Were you able to get in contact? Sorry for the constant annoyance. It looks like a PR is available to solve the issue.
erwanriou commentedon Sep 30, 2019
+1
Awaiting feedback. Go the exact same issue now that i started update all my react libraries