Warnings: componentWillReceiveProps in strict mode, Legacy context API, findDOMNode is deprecated #4094

Activity

1. bladey

   added

   issue/bug-confirmedIssues about a bug that has been confirmed by a maintainerIssues about a bug that has been confirmed by a maintainer

   issue/reviewedIssue has recently been reviewed (mid-2020)Issue has recently been reviewed (mid-2020)

   on Jun 18, 2020
2. bladey

   self-assigned this

   on Jun 18, 2020
3. giangr21 commented on Jun 18, 2020

   

   giangr21

   on Jun 18, 2020 · Hidden as duplicate

   show commentMore actions
4. Sine99 commented on Jun 19, 2020

   

   Sine99

   on Jun 19, 2020 · Hidden as duplicate

   show commentMore actions
5. manvydasu commented on Jun 19, 2020

   

   manvydasu

   on Jun 19, 2020

   Last edited by manvydasu

   Contributor

   More actions

   So basically someone would have to create a PR and replace legacy component lifecycle methods with newer version: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#migrating-from-legacy-lifecycles

   However, looking at usages and code inside of UNSAFE_componentWillReceiveProps , it might not be so straightforward.
6. stak99 commented on Jun 28, 2020

   

   stak99

   on Jun 28, 2020 · Hidden as duplicate

   show commentMore actions
7. corysimmons commented on Jun 29, 2020

   

   corysimmons

   on Jun 29, 2020

   Last edited by corysimmons

   More actions

   For anyone else going insane over this, you can disable those warnings (and other, actually helpful ones) by commenting out <React.StrictMode> in index.js. Just remember to uncomment it a few times a day to get the helpful warnings.

   ---

   Update: Stop confused-face'ing me you monsters! 😭

   👍React with 👍16Reacted by Estefan, Gian Grassi, Vinícius Fraga Modesto, Celo Reis, alongalperin, xuan, Barak, Ryan Milton, David Öhlin, Jessica and 6 more

   👎React with 👎29Reacted by Henrik Myntti, Zahid Saeed, Nikolai Gorte, Justin Leider, Washington Soares, Zach Silveira, Jhony Penagos, Josh Cole, Bernt Christian Egeland, Murat BEŞER and 19 more

   😄React with 😄8Reacted by David Öhlin, Laura Juo-Hsin Chen, Breno Baptista, milad geravand, Edoardo L'Astorina, Bhavin Agarwal, jwrightEA and Hasibullah Mahmood

   😕React with 😕84Reacted by Guilherme de Oliveira Costa, Vinícius Fraga Modesto, hellgatex31, Sean Washington, Misael, Celo Reis, Sergio A. Trejo, Brandon T. Kowalski, James, Juan Pablo Solano and 74 more

   ❤️React with ❤️1Reacted by neonwebdev
8. martijnhalekor commented on Jul 15, 2020

   

   martijnhalekor

   on Jul 15, 2020 · Hidden as duplicate

   show commentMore actions
9. roberto-souza commented on Jul 20, 2020

   

   roberto-souza

   on Jul 20, 2020 · Hidden as duplicate

   show commentMore actions
10. OlegPuzankin commented on Jul 24, 2020

    

    OlegPuzankin

    on Jul 24, 2020

    More actions

    Can anyone say - are these warnings critical and can we expect the developers to fix that in the future?
11. corysimmons commented on Jul 24, 2020

    

    corysimmons

    on Jul 24, 2020

    More actions

    @OlegPuzankin They aren't critical in React 16.x.x, in React 17+ I suspect all the deprecated UNSAFE_xyz methods will be removed so any libraries depending on those methods will stop working.

    Yes, the maintainer is aware of it and has it on their todo list.

    👍React with 👍7Reacted by bwilson, Abhijeet Singh, Anton Lvovych, Yoav, code-jongleur, Gal Bracha and Dezzymei
12. bladey

    added

    issue/reviewedIssue has recently been reviewed (mid-2020)Issue has recently been reviewed (mid-2020)

    and removed

    issue/reviewedIssue has recently been reviewed (mid-2020)Issue has recently been reviewed (mid-2020)

    on Aug 24, 2020
13. BraveEvidence commented on Oct 24, 2020

    

    BraveEvidence

    on Oct 24, 2020

    More actions

    React v17 has been released. Someone please fix this issue

    👍React with 👍20Reacted by Shyam Gupta, Ben Kirchner, Lucas Viegas, Cássio Lacerda, Paulo Carvalho, Javier Cestau, cedricfarinazzo, Ismael Barrios R, omaksi, Goga Gogoberishvili and 10 more

    😕React with 😕5Reacted by Meriadec Pillet, Ilham, Thomas LEDUC, Ante and Rishi Tank
14. 2 remaining items

    Load more

15. corysimmons commented on Nov 25, 2020

    

    corysimmons

    on Nov 25, 2020

    Last edited by corysimmons

    More actions

    @Methuselah96 Is that a drop-in replacement that won't spam the UNSAFE warnings?

    Edit: Seems to have the same UNSAFE warnings and others are submitting PRs to that project... so... why not just PR this project instead? 🤔
16. Methuselah96 commented on Nov 25, 2020

    

    Methuselah96

    on Nov 25, 2020

    Last edited by Methuselah96

    Collaborator

    More actions

    @corysimmons I haven't finished the changes necessary to remove the UNSAFE warnings in the fork.

    I didn't make a PR for this project, because at the time, it had been several months since any PR had been merged and half a year since a new version had been released. I planned on creating a PR once I had finished all the changes necessary.

    As long as this project is actually maintained, I'll make PRs here and hopefully archive my fork.

    EDIT: I've made a PR: #4313.

    👍React with 👍15Reacted by Finn O'Connor, Bernt Christian Egeland, Meriadec Pillet, Nahuel Krowicki, Cory Simmons, Matheus de Castro Diori, Justin Leider, Jawwad Zafar, Jody Heavener, Eric and 5 more

    🎉React with 🎉8Reacted by Bernt Christian Egeland, Nahuel Krowicki, Zach Wegrzyniak, Cory Simmons, Dollique, Jose Padilla, Dezzymei and Adam Clemons
17. bwilson commented on Nov 25, 2020

    

    bwilson

    on Nov 25, 2020 via email

    More actions

    Thanks for your efforts!

    …

    On Wed, Nov 25, 2020 at 2:33 PM Nathan Bierema ***@***.***> wrote: @corysimmons <https://github.com/corysimmons> I haven't finished the changes necessary to remove the UNSAFE warnings in the fork. I didn't make a PR for this project, because at the time, it had been several months since any PR had been merged and half a year since a new version had been released. I planned on creating a PR once I had finished all the changes necessary. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4094 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYL5RGUSQDUWO7JONCTCTSRVSX3ANCNFSM4OBIGG7Q> .
18. flora8984461 commented on Dec 2, 2020

    

    flora8984461

    on Dec 2, 2020

    More actions

    Have the same issue here.
19. ebonow

    added this to the 3.2 milestone on Dec 2, 2020
20. Methuselah96

    modified the milestones: 3.2, 4.0 on Dec 12, 2020
21. Dezzymei commented on Jan 18, 2021

    

    Dezzymei

    on Jan 18, 2021

    More actions

    I am still getting this issue. I thought this was working with react 17?

    👍React with 👍3Reacted by David Thomas, jordyvandomselaar and Ochaun Marshall
22. ebonow

    removed this from the 4.0 milestone on Jan 22, 2021
23. ebonow

    linked a pull request that will close this issueRemove usages of UNSAFE React methods #4313on Jan 22, 2021
24. JedWatson

    closed this as completedin #4313on Jan 22, 2021
25. corysimmons commented on Jan 22, 2021

    

    corysimmons

    on Jan 22, 2021

    More actions

    @Methuselah96 Thank you, Hero!

    👍React with 👍8Reacted by Eric Bonow, V, Matthew Reishus, Aksel, brian staruk, Brian Olore, Carlos and Jose Padilla
26. Ochaun commented on Feb 25, 2021

    

    Ochaun

    on Feb 25, 2021

    More actions

    Still getting this issue on 4.1.0 for the Animated Select.
27. ebonow commented on Feb 25, 2021

    

    ebonow

    on Feb 25, 2021

    Collaborator

    More actions

    @Ochaun this is being tracked in #4456
28. alwaysblank

    added a commit that references this issue on Jun 15, 2021

    Update react-select

    ...

    2d28740