Skip to content

Fix scrolling issues #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vadimka123 wants to merge 2 commits into from
Closed

Fix scrolling issues #4484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5bbda
fix scroll issues
Mar 10, 2021
4e10d6c
reformat code
Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions packages/react-select/src/internal/useScrollCapture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,17 @@ export default function useScrollCapture({
},
[handleEventDelta]
);
const onMouseDown = useCallback((event: SyntheticMouseEvent<HTMLElement>) => {
// set mouse start so we can calculate mousemove delta
touchStart.current = event.clientY;
}, []);
const onMouseUp = useCallback(
(event: SyntheticMouseEvent<HTMLElement>) => {
const deltaY = event.clientY - touchStart.current;
handleEventDelta(event, deltaY);
},
[handleEventDelta]
);

const startListening = useCallback(
el => {
Expand All @@ -113,8 +124,14 @@ export default function useScrollCapture({
if (typeof el.addEventListener === 'function') {
el.addEventListener('touchmove', onTouchMove, notPassive);
}
if (typeof el.addEventListener === 'function') {
el.addEventListener('mousedown', onMouseDown, notPassive);
}
if (typeof el.addEventListener === 'function') {
el.addEventListener('mouseup', onMouseUp, notPassive);
}
},
[onTouchMove, onTouchStart, onWheel]
[onTouchMove, onTouchStart, onWheel, onMouseDown, onMouseUp]
);

const stopListening = useCallback(
Expand All @@ -132,8 +149,14 @@ export default function useScrollCapture({
if (typeof el.removeEventListener === 'function') {
el.removeEventListener('touchmove', onTouchMove, false);
}
if (typeof el.removeEventListener === 'function') {
el.removeEventListener('mousedown', onMouseDown, false);
}
if (typeof el.removeEventListener === 'function') {
el.removeEventListener('mouseup', onMouseUp, false);
}
},
[onTouchMove, onTouchStart, onWheel]
[onTouchMove, onTouchStart, onWheel, onMouseDown, onMouseUp]
);

useEffect(() => {
Expand Down