Skip to content

fix 4749: prevent Select from rendering menu until after first render. - #4750

Closed
mthorning wants to merge 1 commit into
JedWatson:masterfrom
mthorning:fix-4749
Closed

mthorning wants to merge 1 commit into
JedWatson:masterfrom
mthorning:fix-4749

Conversation

@mthorning

@mthorning mthorning commented Sep 6, 2021 •

Copy link
Copy Markdown

The MenuPortal component looks for the existence of the controlElement which is saved in a ref (controlRef in the Select component). This does not exist on the first render. These changes demonstrate the issue, I realise that this may not be the ideal way to fix it but it was the cleanest way to show the problem/solution. I would appreciate some advice on next steps. Thank you.

@changeset-bot

changeset-bot Bot commented Sep 6, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9f2d372

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci

codesandbox-ci Bot commented Sep 6, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f2d372:

Sandbox Source
react-codesandboxer-example Configuration

@mthorning mthorning changed the title Fix 4749: prevent Select from rendering menu until after first render so that c… fix 4749: prevent Select from rendering menu until after first render so that c… Sep 6, 2021
@mthorning mthorning changed the title fix 4749: prevent Select from rendering menu until after first render so that c… fix 4749: prevent Select from rendering menu until after first render. Sep 6, 2021
@ebonow ebonow linked an issue Oct 5, 2021 that may be closed by this pull request
@mthorning mthorning closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defaultMenuIsOpen doesn't work with menuPortalTarget

1 participant