Skip to content

Add phone voicemail webhook events - #453

Merged
Jericho merged 4 commits into
Jericho:developfrom
ivan-pavlik:feature/phone_voicemail_webhooks
Nov 28, 2025
Merged

Jericho merged 4 commits into
Jericho:developfrom
ivan-pavlik:feature/phone_voicemail_webhooks

Conversation

@ivan-pavlik

Copy link
Copy Markdown
Contributor

This PR adds the following webhook events:

  • phone.voicemail_deleted
  • phone.voicemail_permanently_deleted
  • phone.voicemail_received
  • phone.voicemail_received_for_access_member
  • phone.voicemail_transcript_completed

Models:

  • PhoneVoicemailEvent: base model with callee's AccountId property.
  • PhoneVoicemailReceivedForAccessMemberEvent is not inherited from PhoneVoicemailEvent as here AccountId represents access member's account id.
  • merged PhoneCallRecordingCalleeNumberType and PhoneCallRecordingCallerNumberType into PhoneCallNumberType enum: values are the same (though 'callee' case has one more possible number type), and it is not related to recordings only. Note that this is a breaking change (if library client explicitly used one of the old enums they should change it to the new enum).
  • new models for the voicemail and transcript. I see some differences in the voicemail properties returned by webhook events and API endpoints, so to simplify adding these endpoints (at some point later on) I've added VoicemailBase with the properties common for voicemail webhooks and endpoints, and child WebhookVoicemail with webhook specific properties.

Unit tests:

  • added unit tests for the new webhook events
  • adjusted and aligned property values in phone voicemail webhook events json data to simplify checks

@Jericho Jericho added the Enhancement New feature or request label Nov 28, 2025
@Jericho Jericho added this to the 0.102.0 milestone Nov 28, 2025

@Jericho Jericho left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you for your contribution.

@Jericho

Jericho commented Nov 28, 2025

Copy link
Copy Markdown
Owner

Another excellent PR!

@Jericho
Jericho merged commit 366c230 into Jericho:develop Nov 28, 2025
1 of 3 checks passed
@ivan-pavlik
ivan-pavlik deleted the feature/phone_voicemail_webhooks branch November 28, 2025 15:02
@Jericho

Jericho commented Dec 1, 2025

Copy link
Copy Markdown
Owner

🎉 This issue has been resolved in version 0.102.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants