Skip to content

Add phone account/group settings webhook events - #460

Merged
Jericho merged 3 commits into
Jericho:developfrom
ivan-pavlik:feature/phone_settings_webhooks
Dec 8, 2025
Merged

Jericho merged 3 commits into
Jericho:developfrom
ivan-pavlik:feature/phone_settings_webhooks

Conversation

@ivan-pavlik

Copy link
Copy Markdown
Contributor

This PR adds the following webhook events:

  • phone.account_settings_updated
  • phone.group_settings_updated

Hopefully I've correctly added all the models and properties from the specification into code -)

Models (all files are added under PhoneAccountSettings subfolder as amount is quite high and they are settings specific):

  • SettingGroupBase: properties common for all setting groups (Enabled is mandatory, other are optional)
  • CommonAccountAndGroupSettings: contains settings properties that are applicable to account and group
  • AccountSettings: inherited from CommonAccountAndGroupSettings, adds account specific settings properties
  • GroupSettings: inherited from CommonAccountAndGroupSettings, adds group specific settings properties
  • various enums and models used in settings (all can be reused for account and group settings API endpoints as well)
  • WebhookAccountSettings and WebhookGroupSettings: models to match data as received in webhook payload
  • two new webhook events - PhoneAccountSettingsUpdatedEvent and PhoneGroupSettingsUpdatedEvent

Unit tests:

  • added unit tests for the new webhook events with all possible settings

P.S. Now phone webhooks set is completed 😀
I will probably have less free time for contribution going forward (at least until the Christmas/New Year holidays) but when I get a chance I will try to work on adding contact center webhook events if that's OK.

@Jericho Jericho added the Enhancement New feature or request label Dec 8, 2025
@Jericho Jericho added this to the 0.104.0 milestone Dec 8, 2025
@Jericho

Jericho commented Dec 8, 2025

Copy link
Copy Markdown
Owner

I will probably have less free time for contribution going forward (at least until the Christmas/New Year holidays) but when I get a chance I will try to work on adding contact center webhook events if that's OK.

Enjoy some well deserved down time. Looking forward to more of your contributions in the new year!

@Jericho Jericho left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thank you for your contribution.

@Jericho
Jericho merged commit cce8032 into Jericho:develop Dec 8, 2025
2 of 3 checks passed
@ivan-pavlik
ivan-pavlik deleted the feature/phone_settings_webhooks branch December 8, 2025 16:27
@Jericho

Jericho commented Dec 12, 2025

Copy link
Copy Markdown
Owner

🎉 This issue has been resolved in version 0.104.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants