Add phone account/group settings webhook events - #460
Merged
Jericho merged 3 commits intoDec 8, 2025
Merged
Conversation
Owner
Enjoy some well deserved down time. Looking forward to more of your contributions in the new year! |
Jericho
approved these changes
Dec 8, 2025
Jericho
left a comment
Owner
There was a problem hiding this comment.
Looks good to me!
Thank you for your contribution.
Owner
|
🎉 This issue has been resolved in version 0.104.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following webhook events:
Hopefully I've correctly added all the models and properties from the specification into code -)
Models (all files are added under
PhoneAccountSettingssubfolder as amount is quite high and they are settings specific):SettingGroupBase: properties common for all setting groups (Enabledis mandatory, other are optional)CommonAccountAndGroupSettings: contains settings properties that are applicable to account and groupAccountSettings: inherited fromCommonAccountAndGroupSettings, adds account specific settings propertiesGroupSettings: inherited fromCommonAccountAndGroupSettings, adds group specific settings propertiesWebhookAccountSettingsandWebhookGroupSettings: models to match data as received in webhook payloadPhoneAccountSettingsUpdatedEventandPhoneGroupSettingsUpdatedEventUnit tests:
P.S. Now phone webhooks set is completed 😀
I will probably have less free time for contribution going forward (at least until the Christmas/New Year holidays) but when I get a chance I will try to work on adding contact center webhook events if that's OK.