Pack zopfli's Apache-2.0 license into the Zopfli.Net nupkg - #4
Merged
Conversation
Zopfli.Net bundles compiled zopfli/zopflibridge binaries in runtimes/<rid>/native/, but nothing packed a copy of zopfli's own license alongside them - Apache-2.0 section 4(a) requires redistributing a copy of the license with the work. Packs native/zopfli/COPYING to licenses/zopfli/COPYING in the nupkg. Verified by hand: `dotnet pack` then unzipping the resulting .nupkg - the file lands at exactly that path with the real Apache-2.0 text, not (as two earlier attempts at the PackagePath value produced) nested under an extra COPYING/COPYING or COPYING.txt/COPYING folder. For a single None item, PackagePath has to be a directory prefix ending in `/` - NuGet's pack target always appends the source item's own filename, it doesn't rename. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nopu9gA5CuVcGZFJH2Nouh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zopfli.Net bundles compiled zopfli/zopflibridge binaries in runtimes//native/, but nothing packed a copy of zopfli's own license alongside them - Apache-2.0 section 4(a) requires redistributing a copy of the license with the work. Packs native/zopfli/COPYING to licenses/zopfli/COPYING in the nupkg.
Verified by hand:
dotnet packthen unzipping the resulting .nupkg - the file lands at exactly that path with the real Apache-2.0 text, not (as two earlier attempts at the PackagePath value produced) nested under an extra COPYING/COPYING or COPYING.txt/COPYING folder. For a single None item, PackagePath has to be a directory prefix ending in/- NuGet's pack target always appends the source item's own filename, it doesn't rename.Claude-Session: https://claude.ai/code/session_01Nopu9gA5CuVcGZFJH2Nouh