Repository navigation
fix(web): settings pages follow one style and show only what matters - #906
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vironments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 11, 2026
This was referenced Nov 12, 2026
Mjones13
added a commit
that referenced
this pull request
Nov 12, 2026
Integrates #906 (settings style pass) and #963 (packaged helper fault observations). - StorageSettings: upstream's restructured worktree cleanup section is kept; #906's shorter copy and COVERAGE_LABEL titles and switch labels are applied to it. - RemoteAdmissionSettings: #906's layout, with the sync's plan-agent selection. - WorkstreamsSetupStatus: #906's offline status line under upstream's renamed state-sync lint rule. - LinkedEnvironmentsSettings: upstream's renewal note for an already-linked machine replaces the earlier mode note that #906 had trimmed. - Update action rows may shrink: the sync's real-CSS narrow-width test showed #906's non-shrinking row overflowing to 589px once a status line appeared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings sections added by the Jones fork didn't follow the conventions of the rest of the settings pages. They used hand-rolled containers and headings, paragraphs of internal explanation, operation UUIDs, raw codes, ISO timestamps, and repeated status lines. This made Connections, the Jones Code page, Integrations → Browser, and parts of General/Storage heavy and hard to scan (owner report with screenshots).
Change
Presentation only: no behaviour, API or persistence changes. Everything uses the existing
settingsLayoutprimitives (SettingsPageContainer/SettingsSection/SettingsRow), with one short description per row. Secondary detail moves into tooltips or a collapsed Details disclosure.SettingsPageContainerlike every other route.Scope and approval
Requested directly by the repository owner as a settings-wide style and density pass. The change is limited to settings presentation in
apps/web.apps/web/src/jones/installStatus/**is deliberately untouched (open #902).Verification
Current candidate
f9af8681f493424d76c713f6f6f4f9309390dbd4includes canonical main3f3328a54c4f6db91d9c4790a97b32c9f3f5fe12through a normal merge. The settings delta remains the original 26 files; newerinstallStatus/**owners are preserved.Native Preview source comparison
Two separately built production web renderers were exercised through Jones Code's native
preview_*tools on the VPS, with task-owned synthetic state. Comparison:3f3328a54c4f6db91d9c4790a97b32c9f3f5fe12; candidate:f9af8681f493424d76c713f6f6f4f9309390dbd4. CSS viewport 1440 × 1000, DPR 2, light theme, Inter loaded in both. Screenshots show source before/after, not two states within one build.Native actions/readbacks: Workstreams Details opens by click and by Enter, exposes diagnostic codes/guides, and closes by Enter. Refresh changed the backend-observed setup timestamp from
2026-11-11T13:31:09.550Zto2026-11-11T13:32:20.461Z. Thread activity window enabled its amount control, remained enabled after a full reload, and was restored to off. Connections preserves the unavailable-owner state without offering evaluation actions; Browser preserves its server host selector.Served
index.htmlSHA-256 matches each locally built output: beforeb835e0678cbcc7c3f6449e4cb779746db2665982623aca3ed67c1accc7a5cb30; candidate49eeb915e7d7852730d5063a526605898c42531ff78d92578655e0f5d5aa08d6. Full output-file hashes, capture hashes and action readbacks are retained in the task's native-evidence receipt. Runtime branding is 0.1.2 and has no source stamp; source correspondence is established by the recorded clean-source build sequence and output hashes.Coverage limits: Linux shared renderer; unconfigured Workstreams, no saved remote environments, unavailable admission-owner access, and a server-only browser host. Provider/model saves, installer status fixtures and desktop-host configuration are covered by the focused browser tests; they were not exercised against real providers or installers in native Preview. Packaged desktop/mobile and live fleet operations were not tested. A comparison-only development cache/HMR hook error in untouched SidebarEnvironmentFilters was avoided by building both production renderers; no product source changed for evidence.
Expanded Workstreams diagnostics:
Original implementation: Claude Opus 5.5 coordinator and five Claude Opus subagents in Claude Code desktop. Integration, checks and native evidence: GPT-6.1 Sol/high in Jones Code Codex harness. Independent correctness review: GPT-6.1 Sol/max.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.