Repository navigation
Fix computing code shasum inside docker build - #4436
Merged
mnaamani merged 4 commits intoNov 16, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mnaamani
force-pushed
the
node-docker-version-string-fix
branch
from
November 13, 2022 07:55
951d33b to
79fd6df
Compare
mnaamani
marked this pull request as ready for review
November 13, 2022 16:04
Member
Author
|
I also updated docker image build to include the compressed .wasm file which we now use for the runtime upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing shasum of code inside of docker build will not produce the same result as computing on the repo because
the files are copied and their dates changewe weren't copying the joystream-node.Dockerfile and setting the RUNTIME_PROFILE env var.So decided to just pass in the computed value as a build arg.