Repository navigation
Ephesus runtime upgrade ci - #4569
Merged
mnaamani merged 117 commits intoMar 2, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dobertRowneySr
added
network-integration-test
dobertRowneySr
force-pushed
the
ephesus-runtime-upgrade-ci
branch
from
January 31, 2023 07:23
8d72584 to
7483623
Compare
added 2 commits
January 31, 2023 08:31
added 2 commits
February 27, 2023 17:46
added 11 commits
February 28, 2023 06:33
mnaamani
reviewed
Mar 1, 2023
| const coreJob = runtimeUpgradeProposalJob || councilJob | ||
|
|
||
| // All other jobs should be executed after coreJob | ||
| const coreJob = councilJob || runtimeUpgradeProposalJob |
Member
There was a problem hiding this comment.
This change is not correct.
If a runtime upgrade job is running then the core job is the runtime upgrade job (which itself depends on council job). Or you will have tests potentially running before and after upgrade.
added 11 commits
March 1, 2023 09:04
Collaborator
Author
|
there's a problem with the full scenario itself see: #4679 |
mnaamani
self-requested a review
March 2, 2023 10:11
mnaamani
approved these changes
Mar 2, 2023
mnaamani
left a comment
mnaamani
left a comment
Member
There was a problem hiding this comment.
LGTM
Failing test in full scenario will be addressed separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #4555
This needs #4599 in order to have
joystream-node.compact.compressed.wasmas runtime code for the proposal in order to avoid triggering a block weight exceeded error.This also needs #4608 as it is based on top of that
┆Issue is synchronized with this Asana task by Unito