Skip to content

JoystreamJS: Generate commitment from arbitrary bytes source - #4584

Merged
mnaamani merged 2 commits into
Joystream:masterfrom
thesan:joystream-js-arbitrary-bin-source
Nov 7, 2023
Merged

mnaamani merged 2 commits into
Joystream:masterfrom
thesan:joystream-js-arbitrary-bin-source

Conversation

@thesan

@thesan thesan commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

This is needed by Joystream/pioneer#4095 becausefs is not available in the browser. Instead the payload file is provided to the browser as a File.

@thesan
thesan requested a review from zeeshanakram3 January 30, 2023 08:27
@vercel

vercel Bot commented Jan 30, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
pioneer-testnet ⬜️ Ignored (Inspect) Jan 30, 2023 at 10:31AM (UTC)

@thesan
thesan force-pushed the joystream-js-arbitrary-bin-source branch from 8b2434b to ccbfd21 Compare January 30, 2023 10:31
@thesan
thesan changed the base branch from ephesus to master September 27, 2023 08:31
@thesan
thesan changed the base branch from master to nara September 27, 2023 08:31
@thesan
thesan changed the base branch from nara to master September 27, 2023 08:31
@thesan

thesan commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator Author

@zeeshanakram3 BTW this is needed in Pioneer here

@zeeshanakram3 zeeshanakram3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani
mnaamani merged commit bcddf45 into Joystream:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants