Skip to content

Crt release v1 - #4871

Merged
mnaamani merged 214 commits into
Joystream:narafrom
dobertRowneySr:crt-release-v1
Nov 2, 2023
Merged

mnaamani merged 214 commits into
Joystream:narafrom
dobertRowneySr:crt-release-v1

Conversation

@dobertRowneySr

@dobertRowneySr dobertRowneySr commented Sep 14, 2023 •

Copy link
Copy Markdown
Collaborator

This PR contains all the fixes for v1 in order for allow Orion (and Atlas) to progress

Changes (and issues addressed)

┆Issue is synchronized with this Asana task by Unito

@mnaamani mnaamani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments.
The most important issue however is the need to initialize the amm_treasury_account with existential deposit which we do for all module accounts, with an on_runtime_update migration.

Comment thread runtime-modules/content/src/lib.rs Outdated
Comment thread query-node/mappings/src/content/channel.ts Outdated
Comment thread query-node/mappings/src/content/channel.ts Outdated
Comment thread query-node/mappings/src/proposals.ts
Comment thread runtime-modules/project-token/src/lib.rs
Comment thread runtime-modules/project-token/src/lib.rs Outdated
Comment thread runtime-modules/project-token/src/migrations.rs Outdated
Comment thread runtime-modules/project-token/src/migrations.rs Outdated
Comment thread yarn.lock Outdated

@mnaamani mnaamani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just some minor points.

Comment thread runtime/src/lib.rs Outdated
Comment thread tsconfig.json Outdated
Comment thread runtime-modules/project-token/Cargo.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants