Skip to content

Update to polkadot v0.9.41 - #4932

Merged
mnaamani merged 14 commits into
Joystream:narafrom
mnaamani:nara-update-to-polkadot-v0.9.41
Nov 7, 2023
Merged

mnaamani merged 14 commits into
Joystream:narafrom
mnaamani:nara-update-to-polkadot-v0.9.41

Conversation

@mnaamani

@mnaamani mnaamani commented Oct 15, 2023 •

Copy link
Copy Markdown
Member

Fixes #4918

  • update to use joystream substrate fork of polkadot-v0.9.41 branch + related fixes
  • Re-enable renaming pallet BagsList to VoterList to be inline with polkadot (to ensure polkadot-js apps staking app compatibility) after modifying the migration in substrate to skip "problematic" post upgrade check.
  • bump wasmtime crate to v6.0.2
  • bump trie-db to v0.27.1

┆Issue is synchronized with this Asana task by Unito

@mnaamani
mnaamani marked this pull request as ready for review October 16, 2023 06:19
@bedeho bedeho mentioned this pull request Oct 16, 2023
@mnaamani

Copy link
Copy Markdown
Member Author

ref: #4736 (comment)

@dobertRowneySr dobertRowneySr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no major remarks
The question on the stackexchange is still unanswered.
If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?

@mnaamani

mnaamani commented Nov 6, 2023

Copy link
Copy Markdown
Member Author

If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?

No, I'm pretty sure it does move based on looking at the implementation and testing the chain to confirm nothing was at the prefix anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants