Repository navigation
hotfix: QueryNode handling of membership handle - #4950
Merged
Merged
Conversation
dobertRowneySr
suggested changes
Oct 30, 2023
dobertRowneySr
self-requested a review
October 30, 2023 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
If member handle has non-valid utf-8 chars and is replaced with the
�replacement character, two unique (at byte level) handles when converted to string can actually become identical, breaking the uniqueness constraint in the database for the handle column.Solution:
Update query-node schema to: