Skip to content

Add vested budget spending tests and mappings - #5123

Merged
kdembler merged 4 commits into
Joystream:luxorfrom
thesan:luxor/vested-wg-spending-qn
Apr 8, 2024
Merged

kdembler merged 4 commits into
Joystream:luxorfrom
thesan:luxor/vested-wg-spending-qn

Conversation

@thesan

@thesan thesan commented Apr 3, 2024

Copy link
Copy Markdown
Collaborator

Addresses #5118

(Previous PR: dobertRowneySr#15)

@thesan
thesan requested a review from zeeshanakram3 April 3, 2024 16:22
@thesan

thesan commented Apr 4, 2024 •

Copy link
Copy Markdown
Collaborator Author

@zeeshanakram3 @mnaamani I think the build failed with

../../query-node/start.sh: line 11: docker-compose: command not found

https://github.com/Joystream/joystream/actions/runs/8542138020/job/23403106131?pr=5123#step:14:32047

Same thing for the network test build:
https://github.com/Joystream/joystream/actions/runs/8542138019/job/23403409849?pr=5123#step:8:48

Has there been some changes to the runner ?

@mnaamani

mnaamani commented Apr 4, 2024 •

Copy link
Copy Markdown
Member

@zeeshanakram3 @mnaamani I think the build failed with

../../query-node/start.sh: line 11: docker-compose: command not found

https://github.com/Joystream/joystream/actions/runs/8542138020/job/23403106131?pr=5123#step:14:32047

Same thing for the network test build: https://github.com/Joystream/joystream/actions/runs/8542138019/job/23403409849?pr=5123#step:8:48

Has there been some changes to the runner ?

Yes I think it is quite possible the newer runners are installing newer versions of docker tools which do not include the docker-compose command, in favor of using docker compose sub command.

Perhaps we should update our scripts.

Strange in your other PR it works fine and it is using the same runner version https://github.com/Joystream/joystream/actions/runs/8551543087/job/23430768153?pr=5124#step:1:1

@kdembler
kdembler merged commit 713d105 into Joystream:luxor Apr 8, 2024
@thesan

thesan commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator Author

Strange in your other PR it works fine and it is using the same runner version https://github.com/Joystream/joystream/actions/runs/8551543087/job/23430768153?pr=5124#step:1:1

@mnaamani it looks like GH uses these new runners only sometime ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants