add!! with Thunk - #348
Merged
Merged
add!! with Thunk#348
Conversation
oxinabox
added
the
inplace accumulation
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 90.01% 90.03% +0.01%
==========================================
Files 14 14
Lines 541 542 +1
==========================================
+ Hits 487 488 +1
Misses 54 54
Continue to review full report at Codecov.
|
mzgubic
approved these changes
May 7, 2021
| end | ||
| end | ||
|
|
||
| add!!(x::AbstractArray, y::Thunk) = add!!(x, unthunk(y)) |
Member
There was a problem hiding this comment.
if this method didn't exist, add!!(abstract_array, thunk) would just dispatch to the fallback. Now that it does exist, it dispatches to the method below, which saves one accumulation. It's late and my brain hurts and I had to write this down to convince myself that it makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its not as good as
add!!(::AbstractArray, ::InplacableThunk)but if it can be inplace then it still saves 1 allocation (InplaceableThunk woulds save 2)/