Skip to content

Test all kinds of tangent types (Thunk, ZeroTangent, Tangent{T} etc) #159

Description

@oxinabox

This is a generalization of #98 and is a key part of JuliaDiff/ChainRules.jl#408

Lets say we have a tanget dx
we should also test that in it's place we can put @thunk(x̄), as well as ZeroTangent.

Further, following JuliaDiff/ChainRulesCore.jl#286
if dx <: AbstractArray (other than Array) we should test canonicalize(Composite{typeof(x)}, dx)
and conversely
if dx <: Composite{P} where P<:AbstractArray we should test canonicalize(P, dx)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions