Skip to content

WIP: Add the option to test tangent types - #186

Closed
mzgubic wants to merge 1 commit into
masterfrom
mz/project
Closed

mzgubic wants to merge 1 commit into
masterfrom
mz/project

Conversation

@mzgubic

@mzgubic mzgubic commented Jul 2, 2021

Copy link
Copy Markdown
Member

Companion to JuliaDiff/ChainRules.jl#459.

We might want this? To check that the rule returns the correct tangent types.

Note that this needs to be made non-breaking by changing the default to false. We can flip the sign with the next breaking release.

@oxinabox

oxinabox commented Jul 2, 2021

Copy link
Copy Markdown
Member

I'm not sure.
Possibly for testing this we have something better.
For example checking that you can add it to the primal and the result has structual zeros in the same place the primal does.
(indicated for Diagonal by being the right type still)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants