Proof caching: use dependency graph to increase hit rate - #3305
Merged
Conversation
unp1
reviewed
Oct 23, 2023
unp1
reviewed
Oct 23, 2023
Co-Authored-By: Richard Bubel <bubel@cs.tu-darmstadt.de>
FliegendeWurst
marked this pull request as ready for review
October 30, 2023 17:43
unp1
requested changes
Oct 30, 2023
unp1
approved these changes
Oct 30, 2023
unp1
enabled auto-merge
October 30, 2023 18:02
auto-merge was automatically disabled
October 30, 2023 19:40
Head branch was pushed to by a user without write access
WolframPfeifer
requested changes
Nov 3, 2023
WolframPfeifer
left a comment
Member
There was a problem hiding this comment.
Thanks for this improvement! As already discussed, for easier generation of a meaningful changelog, the PR title could be improved. I have only two small remarks/requests (see comments in code).
WolframPfeifer
approved these changes
Feb 6, 2024
WolframPfeifer
left a comment
Member
There was a problem hiding this comment.
Thanks for these nicely documented PR with convenience and efficiency features!
The only small suggestion from my side would be to remove the white box from the icon, such that it fits our icon design better.
Member
Author
This is now done. |
WolframPfeifer
self-requested a review
February 8, 2024 10:33
WolframPfeifer
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when searching for a reference, the entire sequent of the old proof had to be present in the new proof.
Now, only the useful subset of the old sequent has to be present.
Tested by a unit test.
Additional functionality: