Purge sort depending functions in favor of parametric functions - #3773
Merged
Conversation
Drodt
force-pushed
the
purge-sort-depending-fn
branch
from
March 17, 2026 15:34
8256cc5 to
46212b5
Compare
2 tasks
Drodt
marked this pull request as ready for review
March 18, 2026 17:21
Member
Author
|
Delayed until #3120 is merged and invariants are changed from |
unp1
self-requested a review
April 10, 2026 13:23
Member
Author
|
Per the KeY meeting: This PR is truly ready. Eventual syntax improvements are left for future PR (but should be discussed soon!) |
WolframPfeifer
approved these changes
Apr 17, 2026
WolframPfeifer
left a comment
Member
There was a problem hiding this comment.
I reviewed the code and it looks mostly fine, except for a few minor complaints (mostly about comments).
However, when trying to test the PR the GUI, already at start of KeY I get the following exception (even when removing the .key directory):
[16:35:05.483] ERROR XMLResources - Cannot not load help messages in info viewjava.util.InvalidPropertiesFormatException: jdk.internal.org.xml.sax.SAXParseException;
at java.base/jdk.internal.util.xml.PropertiesDefaultHandler.load(PropertiesDefaultHandler.java:85)
at java.base/java.util.Properties.loadFromXML(Properties.java:1003)
at de.uka.ilkd.key.util.XMLResources.getResource(XMLResources.java:58)
at de.uka.ilkd.key.util.XMLResources.<init>(XMLResources.java:36)
at de.uka.ilkd.key.gui.InfoView.<init>(InfoView.java:55)
at de.uka.ilkd.key.gui.InfoView.<init>(InfoView.java:149)
at de.uka.ilkd.key.gui.MainWindow.<init>(MainWindow.java:329)
at de.uka.ilkd.key.gui.MainWindow.getInstance(MainWindow.java:417)
I am not sure if the reason lies really in the PR, also KeY does not crash.
Apart from that and the minor comments, it seems to work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
Replace all sort depending functions from KeY and replace them with parametric functions, e.g., int::select -> select<[int]>.
This PR does not affect behavior. In particular, sequences are not (yet) made parametric and the grammar is not really modified.
SortDependingFunctionis removed.Plan
java.lang.Object::<created>Type of pull request
Ensuring quality
.github/workflows/tests.ymlAdditional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.