fix: build mastra package export#57
Open
mojobeeping wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published
@trysiren/agent-toolkit@0.2.0package declares a./mastrasubpath export, but the published tarball does not include the target files underdist/mastra/*.That makes this documented package entrypoint fail at runtime with
ERR_MODULE_NOT_FOUND.This PR adds
src/mastra/index.tsto thetsupentry list so thedist/mastrabundle and declarations are generated, and externalizes the Mastra peer dependency the same way the OpenAI, LangChain, and AI SDK peer dependencies are handled.Reproduction
Observed result from the published package:
The package metadata points
exports["./mastra"]at:{ "import": "./dist/mastra/index.js", "require": "./dist/mastra/index.js", "types": "./dist/mastra/index.d.ts" }But the published tarball has no
dist/mastrafiles.Validation
Ran from
typescript/:npm run build npm run type-check npm test -- --runInBand git diff --check NPM_CONFIG_CACHE=/tmp/mojobeep-npm-cache npm pack --json --ignore-scriptsThe packed tarball now includes:
I also extracted the packed tarball into a clean temp directory and verified both loaders resolve the fixed entrypoint:
One unrelated check still fails before reaching changed files: