Declare runtime plugin service dependencies - #165
Merged
Merged
Conversation
ldsenow
marked this pull request as ready for review
September 29, 2026 14:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4fdfc13fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Third Cordis-inspired increment: a trusted built-in Webhook plugin can declare requires: { http: "api" } and use the named HTTP plugin's client with a relative webhook URL. The registry validates the provider and service, activates providers first in ConnectAllAsync, exposes active dependencies in composition, blocks provider disconnect/replacement while in use, and tears down dependents first on Host shutdown. Dependency denials are recorded as no-effect management failures.
HTTP and Webhook URLs now reject non-HTTP schemes; a dependent Webhook URL cannot move the initial request to another origin. Rejected dependent URLs finalize admitted management operations as Failed; a provider replacement blocked by an active dependent returns HTTP 409.
Verification
The skipped tests need Docker's npipe endpoint, Windows symlink privileges, or a configured live Echo HTTP endpoint.
Boundary
This is process-local composition among trusted Host connectors. It does not create a persistent service grant, credential broker, Tenant isolation, external plugin sandbox, or automatic dependency reconciliation after restart. HTTP redirects and egress still follow Host deployment policy. See docs/implementation/2026-09-29-plugin-service-dependencies.md.