Repository navigation
fix(kong): select PodDisruptionBudget pods with the Deployment selector labels - #1593
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PodDisruptionBudget in the
kongandkong-ai-gatewaycharts built its selector fromkong.metaLabels, which includeshelm.sh/chartandapp.kubernetes.io/version. An upgrade that changes either label updates the PDB selector immediately, while the running pods keep the old values. Until the rollout replaces them, the PDB covers none of those pods, so a node drain can evict all of them at once.This PR switches the PDB selector to
kong.selectorLabels, the same labels the Deployment uses for its own selector (app.kubernetes.io/name,app.kubernetes.io/component,app.kubernetes.io/instance). The PDB metadata labels are unchanged.charts/kong/templates/pdb.yaml,charts/kong-ai-gateway/templates/pdb.yaml: usekong.selectorLabelsinspec.selector.matchLabels.charts/kong/ci/__snapshots__/pdb-default.snap,pdb-always-allow.snap: rebuilt withhelm chartsnap -u.Which issue this PR fixes
Special notes for your reviewer:
policy/v1PodDisruptionBudget selectors are mutable, sohelm upgradeupdates existing PDBs in place.make test.goldenequivalent (helm chartsnap -c ./charts/kong -f ./charts/kong/ci/with the Makefile's--api-versions) passes: 37 snapshots matched.helm lintpasses for both charts.Checklist
mainbranch.