Repository navigation
Fix packed THD interleaved RoPE fusion - #9
Draft
akhauriyash wants to merge 1 commit into
Draft
akhauriyash wants to merge 1 commit into
akhauriyash wants to merge 1 commit into
Conversation
Forward rotary_interleaved into Transformer Engine's packed THD fused path. Without it, MoVA trainer and SGLang apply different rotary layouts and produce invalid off-policy ratios.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rotary_interleavedinto Transformer Engine's fused packed-THD RoPE path.Why
MoVA trains with
rotary_interleaved=Trueand packed THD sequences. The existing fused THD path drops the interleaving flag, so the trainer and SGLang can apply different rotary layouts. That invalidates trainer/inference log-probability parity and importance-sampling ratios.Retain
--no-rope-fusionfor MoVA training until this change is accepted by the full end-to-end parity gate and deployed in the pinned training image.Validation
/mnt/weka/shrd/k2pta/rl360/parity/2135686/megatron-thd-rope-patch-test-2146011/result.json.SHA-256 42096367b13bec5809f214b218c4588391dc7ca5d8e833c40e317ad963fe886e).git diff --checkand AST parsing of all three changed files pass.