Skip to content

Auditing plus fixes for terms-of-use acceptances - #7991

Merged
labkey-adam merged 2 commits into
developfrom
fb_terms_auditing
Sep 1, 2026
Merged

Auditing plus fixes for terms-of-use acceptances#7991
labkey-adam merged 2 commits into
developfrom
fb_terms_auditing

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Rationale

One additional client request and several issues:

  • Request to add auditing of terms acceptance: https://github.com/LabKey/internal-issues/issues/1500
  • In the login API action, pass the authenticated user into the setTerms* methods in addition to the ViewContext. The user isn't set on the ViewContext yet.
  • Fix the login API action MFA case, where the auth response still has a null user
  • When user impersonation is taking place and terms are accepted, we were setting the terms acceptance timestamp for the impersonator (correct), but always reading timestamps for the impersonated user (incorrect).

Related Pull Requests

@labkey-adam
labkey-adam merged commit 7e9c1cf into develop Sep 1, 2026
7 checks passed
@labkey-adam
labkey-adam deleted the fb_terms_auditing branch September 1, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants