Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current token-refresh helper retries the same refresh-token POST up to three times after transport failures. Refresh tokens can rotate on the first successful server-side request. If that response is lost, retrying the old one can yield refresh_token_reused / refresh_token_invalidated and strand an otherwise healthy session.
Fix
This does not restore already revoked tokens; users must re-authenticate those. The risky retry logic predates the latest fork update and exists in upstream main.
Tested in fork PR #33 (Rust tests, Windows and macOS compilation all passed). Related issue: #223.